Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2588)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java

Issue 2164503003: [OfflinePages] Do not start background loading on low-end devices if app has any visible Activities. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resets the SysUtils and ApplicationStatus static state so it does not leak to other robolectric tes… Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java
index 9ff42381c39b8b1f9cf03b3e20c9aee4e8217593..1df2c12d6ff2ff129ea7d5bbe32d0818a5a2f054 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java
@@ -7,8 +7,10 @@ package org.chromium.chrome.browser.offlinepages;
import android.content.Context;
import android.os.Bundle;
+import org.chromium.base.ApplicationStatus;
import org.chromium.base.Callback;
import org.chromium.base.Log;
+import org.chromium.base.SysUtils;
import org.chromium.base.VisibleForTesting;
import org.chromium.chrome.browser.ChromeBackgroundServiceWaiter;
import org.chromium.chrome.browser.offlinepages.interfaces.BackgroundSchedulerProcessor;
@@ -51,6 +53,11 @@ public class BackgroundOfflinerTask {
return false;
}
+ if (SysUtils.isLowEndDevice() && ApplicationStatus.hasVisibleActivities()) {
+ Log.d(TAG, "Application visible on low-end device so deferring background processing");
+ return false;
+ }
+
// Now initiate processing.
processBackgroundRequests(bundle, currentConditions, waiter);

Powered by Google App Engine
This is Rietveld 408576698