Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Side by Side Diff: base/sequenced_task_runner_unittest.cc

Issue 2164503002: Do not delete blink::WebRTCCertificateCallback on non-main thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "base/sequenced_task_runner.h"
6
7 #include "base/bind.h"
8 #include "base/message_loop/message_loop.h"
9 #include "base/run_loop.h"
10 #include "base/threading/thread.h"
11 #include "testing/gtest/include/gtest/gtest.h"
12
13 namespace base {
14 namespace {
15
16 struct DeleteCounter {
17 DeleteCounter(int* counter, scoped_refptr<SequencedTaskRunner> task_runner)
18 : counter_(counter),
19 task_runner_(std::move(task_runner)) {
20 }
21 ~DeleteCounter() {
22 ++*counter_;
23 EXPECT_TRUE(!task_runner_ || task_runner_->RunsTasksOnCurrentThread());
24 }
25
26 int* counter_;
27 scoped_refptr<SequencedTaskRunner> task_runner_;
28 };
29
30 } // namespace
31
32 TEST(SequencedTaskRunnerTest, OnTaskRunnerDeleter) {
33 base::MessageLoop message_loop;
34 base::Thread thread("Foreign");
35 thread.Start();
36
37 scoped_refptr<SequencedTaskRunner> current_thread =
38 message_loop.task_runner();
39 scoped_refptr<SequencedTaskRunner> foreign_thread =
40 thread.task_runner();
41
42 using SequenceBoundUniquePtr =
43 std::unique_ptr<DeleteCounter, OnTaskRunnerDeleter>;
44
45 int counter = 0;
46 SequenceBoundUniquePtr ptr(new DeleteCounter(&counter, current_thread),
47 OnTaskRunnerDeleter(current_thread));
48 EXPECT_EQ(0, counter);
49 foreign_thread->PostTask(
50 FROM_HERE,
51 Bind([](SequenceBoundUniquePtr) {},
52 Passed(std::move(ptr))));
dcheng 2016/07/22 06:12:04 Nit: Passed(&ptr)
tzik 2016/07/22 07:27:21 Done.
53
54 {
55 RunLoop run_loop;
56 foreign_thread->PostTaskAndReply(
57 FROM_HERE,
58 Bind([]{}),
59 run_loop.QuitClosure());
60 run_loop.Run();
61 }
62 EXPECT_EQ(1, counter);
63
64 DeleteCounter* raw = new DeleteCounter(&counter, nullptr);
65 SequenceBoundUniquePtr ptr2(raw, OnTaskRunnerDeleter(foreign_thread));
66 EXPECT_EQ(1, counter);
67
68 thread.Stop();
69 ptr2 = nullptr;
70 ASSERT_EQ(1, counter);
71
72 delete raw;
73 EXPECT_EQ(2, counter);
74 }
75
76 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698