Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 21645003: Add "benchmarks" test suite (Closed)

Created:
7 years, 4 months ago by Jakob Kummerow
Modified:
7 years, 4 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : skip mandreel in Debug; skip --nocrankshaft/--stress-opt variants #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -4 lines) Patch
M .gitignore View 1 chunk +6 lines, -0 lines 0 comments Download
A + test/benchmarks/benchmarks.status View 1 2 chunks +3 lines, -4 lines 0 comments Download
A test/benchmarks/testcfg.py View 1 1 chunk +181 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAL.
7 years, 4 months ago (2013-08-05 10:34:17 UTC) #1
Michael Achenbach
LGTM with comments: benchmarks/octane/mandreel times out in debug. When it passes it takes very long ...
7 years, 4 months ago (2013-08-05 12:33:24 UTC) #2
Jakob Kummerow
7 years, 4 months ago (2013-08-05 14:54:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16056 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698