Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 2164483007: android: Move ResourceExtractor tracing to TraceEvent. (Closed)

Created:
4 years, 5 months ago by Benoit L
Modified:
4 years, 5 months ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Move ResourceExtractor tracing to TraceEvent. Now that we have early trace events, remove the only instance of android.os.Trace in Chrome. Committed: https://crrev.com/2c5fa833d5c1f7991ebefe672571eac01782e2cd Cr-Commit-Position: refs/heads/master@{#406888}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -29 lines) Patch
M base/android/java/src/org/chromium/base/ResourceExtractor.java View 7 chunks +10 lines, -29 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Benoit L
4 years, 5 months ago (2016-07-21 13:42:25 UTC) #2
Yaron
lgtm - I"m assuming early trace events would also "just work" on webview, right?
4 years, 5 months ago (2016-07-21 13:49:36 UTC) #3
Benoit L
On 2016/07/21 13:49:36, Yaron wrote: > lgtm - I"m assuming early trace events would also ...
4 years, 5 months ago (2016-07-21 14:58:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164483007/1
4 years, 5 months ago (2016-07-21 14:58:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/108074)
4 years, 5 months ago (2016-07-21 16:14:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164483007/1
4 years, 5 months ago (2016-07-21 16:42:07 UTC) #10
commit-bot: I haz the power
Failed to apply the patch.
4 years, 5 months ago (2016-07-21 17:33:24 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 17:33:33 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c5fa833d5c1f7991ebefe672571eac01782e2cd
Cr-Commit-Position: refs/heads/master@{#406888}

Powered by Google App Engine
This is Rietveld 408576698