Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: ui/views/word_lookup_client.h

Issue 2164483006: [MacViews] Implemented text context menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed tapted's comments and added a test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/word_lookup_client.h
diff --git a/ui/views/word_lookup_client.h b/ui/views/word_lookup_client.h
index d9c200f5566728032778cb9e267d42a1d74d07fb..52eca1f8a18b13de006ede99f67fabb7e5873ad2 100644
--- a/ui/views/word_lookup_client.h
+++ b/ui/views/word_lookup_client.h
@@ -22,9 +22,18 @@ class VIEWS_EXPORT WordLookupClient {
// displayed at the point, returns a nearby word. |baseline_point| should
// correspond to the baseline point of the leftmost glyph of the |word| in the
msw 2017/01/26 20:59:16 ditto nit about |word| here and below.
spqchan 2017/02/01 00:32:39 Done.
// view's coordinates. Returns false, if no word can be retrieved.
- virtual bool GetDecoratedWordAtPoint(const gfx::Point& point,
- gfx::DecoratedText* decorated_word,
- gfx::Point* baseline_point) = 0;
+ virtual bool GetDecoratedWordAndBaselineAtPoint(
+ const gfx::Point& point,
+ gfx::DecoratedText* decorated_word,
+ gfx::Point* baseline_point) = 0;
+
+ // Retrieves the text that is currently selected with its styling
+ // information. |baseline_point| should correspond to the baseline point of
+ // the leftmost glyph of the |word| in the view's coordinates. Returns
+ // false, if no text can be retrieved.
+ virtual bool GetDecoratedTextAndBaselineFromSelection(
+ gfx::DecoratedText* decorated_text,
+ gfx::Point* baseline_point) = 0;
protected:
virtual ~WordLookupClient() {}

Powered by Google App Engine
This is Rietveld 408576698