Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: ui/gfx/render_text.h

Issue 2164483006: [MacViews] Implemented text context menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed tapted's comments and added a test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/render_text.h
diff --git a/ui/gfx/render_text.h b/ui/gfx/render_text.h
index 567a647f93fb34299d8cc3ffbde06c9c1e36be17..9b3a11d1fd750148660b9b7d00408f7e39b43c28 100644
--- a/ui/gfx/render_text.h
+++ b/ui/gfx/render_text.h
@@ -529,9 +529,17 @@ class GFX_EXPORT RenderText {
// at the point, returns a nearby word. |baseline_point| should correspond to
// the baseline point of the leftmost glyph of the |word| in the view's
msw 2017/01/26 20:59:16 optional nit: |word| is not an identifier here (or
spqchan 2017/02/01 00:32:38 Done.
// coordinates. Returns false, if no word can be retrieved.
- bool GetDecoratedWordAtPoint(const Point& point,
- DecoratedText* decorated_word,
- Point* baseline_point);
+ bool GetDecoratedWordAndBaselineAtPoint(const Point& point,
+ DecoratedText* decorated_word,
+ Point* baseline_point);
+
+ // Retrieves the text at the given |range| along with its styling
+ // information. |baseline_point| should correspond to the baseline point of
+ // the leftmost glyph of the |word| in the view's coordinates. Returns
+ // false, if no word can be retrieved.
+ bool GetDecoratedTextAndBaselineForRange(const Range& range,
+ DecoratedText* decorated_text,
+ Point* baseline_point);
// Retrieves the text in the given |range|.
base::string16 GetTextFromRange(const Range& range) const;

Powered by Google App Engine
This is Rietveld 408576698