[MacViews] Implemented text context menu

content/browser/frame_host/render_widget_host_view_guest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_widget_host_view_guest.h"
 
 #include <utility>
 
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
@@ skipping 453 matching lines @@
       guest_bounds.x() - embedder_bounds.x(),
       // Vertical offset from guest's top to embedder's bottom edge.
       embedder_bounds.bottom() - guest_bounds.y());
 
   RenderWidgetHostViewMacDictionaryHelper helper(platform_view_.get());
   helper.SetTargetView(rwhv);
   helper.set_offset(guest_offset);
   helper.ShowDefinitionForSelection();
 }
 
-bool RenderWidgetHostViewGuest::SupportsSpeech() const {
-  return platform_view_->SupportsSpeech();
-}
-
 void RenderWidgetHostViewGuest::SpeakSelection() {

[nasko, 2017/01/31 15:37:29]

Why does this method stay around and the others are removed? I'd expect they all
go together.

[spqchan, 2017/02/01 00:32:39]

In Mac, there is a menu item in the main menu that lets you select "Speak Text".
If nothing is selection, a message gets sent to the renderer to get all of the
text in the web content. This is async, so we need the method in
RenderWidgetHostView. IsSpeaking() and StopSpeaking() can be removed and handled
in text_services_context_menu because they're not async.

   platform_view_->SpeakSelection();
 }
 
-bool RenderWidgetHostViewGuest::IsSpeaking() const {
-  return platform_view_->IsSpeaking();
-}
-
-void RenderWidgetHostViewGuest::StopSpeaking() {
-  platform_view_->StopSpeaking();
-}
 #endif  // defined(OS_MACOSX)
 
 void RenderWidgetHostViewGuest::LockCompositingSurface() {
   NOTIMPLEMENTED();
 }
 
 void RenderWidgetHostViewGuest::UnlockCompositingSurface() {
   NOTIMPLEMENTED();
 }
 
@@ skipping 148 matching lines @@
         gesture_event.data.scrollUpdate.inertialPhase ==
             blink::WebGestureEvent::MomentumPhase) {
       return;
     }
     host_->ForwardGestureEvent(gesture_event);
     return;
   }
 }
 
 }  // namespace content