ui/gfx/decorated_text_mac.h - Issue 2164483006: [MacViews] Implemented text context menu

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/gfx/decorated_text_mac.h

Issue 2164483006: [MacViews] Implemented text context menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed tapted's comments and added a test Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef UI_GFX_DECORATED_TEXT_MAC_H_

	6 #define UI_GFX_DECORATED_TEXT_MAC_H_

	7

	8 #include "ui/gfx/gfx_export.h"

	9

	10 @class NSAttributedString;

	11

	12 namespace gfx {

	13

	14 struct DecoratedText;

	15

	16 // Returns a NSAttributedString from \|decorated_text\|.
	msw 2017/01/26 20:59:16 optional nit: I'd potentially put this in decorate optional nit: I'd potentially put this in decorated_text.h as DecoratedText::ToNSAttributedString() like CGPoint stuff in ui/gfx/point.* spqchan 2017/02/01 00:32:38 Acknowledged. Show quoted text On 2017/01/26 20:59:16, msw wrote: > optional nit: I'd potentially put this in decorated_text.h as > DecoratedText::ToNSAttributedString() like CGPoint stuff in ui/gfx/point.* Acknowledged.
	17 GFX_EXPORT NSAttributedString* GetAttributedStringFromDecoratedText(

	18 const DecoratedText& decorated_text);

	19

	20 } // namespace gfx

	21

	22 #endif // UI_GFX_DECORATED_TEXT_MAC_H_

OLD	NEW