ui/base/cocoa/DEPS - Issue 2164483006: [MacViews] Implemented text context menu

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/base/cocoa/DEPS

Issue 2164483006: [MacViews] Implemented text context menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix for tapted 2 Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 include_rules = [

	2 "+chrome/app/chrome_command_ids.h",
	tapted 2016/12/19 07:41:21 ui/base can't depend on chrome. I think we will ne ui/base can't depend on chrome. I think we will need to pass this in via the delegate interface. Perhaps IsLookUpAvailable() can take an int* for the command_id to use. Then I think it's OK to keep using the IDS_ versions of the other commands (i.e. those that appear in submenus rather than in the root level menu). However, we can't use `IsTextServicesCommandId` the same way, since we can't guarantee there's no overlap. However, this shouldn't be a big problem, since it's just the lookup command that the root menu should see. spqchan 2016/12/21 01:03:02 That works too. I think we should just take lookup Show quoted text On 2016/12/19 07:41:21, tapted wrote: > ui/base can't depend on chrome. I think we will need to pass this in via the > delegate interface. > > Perhaps IsLookUpAvailable() can take an int* for the command_id to use. > > Then I think it's OK to keep using the IDS_ versions of the other commands (i.e. > those that appear in submenus rather than in the root level menu). > > However, we can't use `IsTextServicesCommandId` the same way, since we can't > guarantee there's no overlap. However, this shouldn't be a big problem, since > it's just the lookup command that the root menu should see. That works too. I think we should just take lookup out completely, since the code would be a bit cleaner too
	3 ]

OLD	NEW