[MacViews] Implemented text context menu

ui/gfx/render_text.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GFX_RENDER_TEXT_H_
 #define UI_GFX_RENDER_TEXT_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 507 matching lines @@
 
   // Retrieves the word displayed at the given |point| along with its styling
   // information. |point| is in the view's coordinates. If no word is displayed
   // at the point, returns a nearby word. |baseline_point| should correspond to
   // the baseline point of the leftmost glyph of the |word| in the view's
   // coordinates. Returns false, if no word can be retrieved.
   bool GetDecoratedWordAtPoint(const Point& point,
                                DecoratedText* decorated_word,
                                Point* baseline_point);
 
+  // Retrieves the text at the given |range| along with its styling
+  // information. |baseline_point| should correspond to the baseline point of
+  // the leftmost glyph of the |word| in the view's coordinates. Returns
+  // false, if no word can be retrieved.
+  bool GetDecoratedTextForRange(const Range& range,
+                                DecoratedText* decorated_text,
+                                Point* baseline_point);
+
   // Retrieves the text in the given |range|.
   base::string16 GetTextFromRange(const Range& range) const;
 
  protected:
   RenderText();
 
   // NOTE: The value of these accessors may be stale. Please make sure
   // that these fields are up to date before accessing them.
   const base::string16& layout_text() const { return layout_text_; }
   const base::string16& display_text() const { return display_text_; }
@@ skipping 176 matching lines @@
   // CURSOR_BACKWARD direction, then in the CURSOR_FORWARD direction. Returns
   // the text length if no valid boundary is found.
   size_t GetNearestWordStartBoundary(size_t index) const;
 
   // Expands |range| to its nearest word boundaries and returns the resulting
   // range. Maintains directionality of |range|.
   Range ExpandRangeToWordBoundary(const Range& range) const;
 
   // Returns the decorated text corresponding to |range|. Returns false if the
   // text cannot be retrieved, e.g. if the text is obscured.
   virtual bool GetDecoratedTextForRange(const Range& range,

[tapted, 2016/12/13 05:11:23]

It's confusing to have a virtual and a non-virtual method with the same name. I
think this needs to be renamed to something like GetDecoratedTextForRangeImpl

[spqchan, 2016/12/15 23:29:01]

How about GetDecoratedTextAndBasepointForRange? If this is good, I can rename
GetDecoratedWordAtPoint and etc to GetDecoratedWordAndBaselineAtPoint 

[tapted, 2016/12/16 07:01:19]

With GetDecoratedTextAndBasepointForRange ->
GetDecoratedTextAndBaselinePointForRange

that's good too. I don't feel strongly (so long as they're different), but a
ui/gfx/OWNER (probably msw) might have a preference.

                                         DecoratedText* decorated_text) = 0;
 
   // Logical UTF-16 string data to be drawn.
   base::string16 text_;
 
   // Horizontal alignment of the text with respect to |display_rect_|.  The
   // default is to align left if the application UI is LTR and right if RTL.
   HorizontalAlignment horizontal_alignment_;
 
   // The text directionality mode, defaults to DIRECTIONALITY_FROM_TEXT.
@@ skipping 126 matching lines @@
   // Lines computed by EnsureLayout. These should be invalidated upon
   // OnLayoutTextAttributeChanged and OnDisplayTextAttributeChanged calls.
   std::vector<internal::Line> lines_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderText);
 };
 
 }  // namespace gfx
 
 #endif  // UI_GFX_RENDER_TEXT_H_