[MacViews] Implemented text context menu

content/browser/renderer_host/render_widget_host_view_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_mac.h"
 
 #import <Carbon/Carbon.h>
 #import <objc/runtime.h>
 #include <OpenGL/gl.h>
 #include <QuartzCore/QuartzCore.h>
@@ skipping 55 matching lines @@
 #include "content/public/browser/web_contents.h"
 #include "gpu/ipc/common/gpu_messages.h"
 #include "skia/ext/platform_canvas.h"
 #include "skia/ext/skia_utils_mac.h"
 #include "third_party/WebKit/public/platform/WebInputEvent.h"
 #import "ui/base/clipboard/clipboard_util_mac.h"
 #include "ui/base/cocoa/animation_utils.h"
 #import "ui/base/cocoa/appkit_utils.h"
 #include "ui/base/cocoa/cocoa_base_utils.h"
 #import "ui/base/cocoa/fullscreen_window_manager.h"
+#include "ui/base/cocoa/text_services_context_menu.h"
 #import "ui/base/cocoa/underlay_opengl_hosting_window.h"
 #include "ui/base/layout.h"
 #include "ui/compositor/compositor.h"
 #include "ui/compositor/layer.h"
 #include "ui/display/display.h"
 #include "ui/display/screen.h"
 #include "ui/events/event_utils.h"
 #include "ui/events/keycodes/keyboard_codes.h"
 #include "ui/gfx/geometry/dip_util.h"
 #include "ui/gfx/geometry/point.h"
@@ skipping 44 matching lines @@
     return render_widget_host_view;
   content::WebContents* guest =
       guest_manager->GetFullPageGuest(web_contents);
   if (!guest)
     return render_widget_host_view;
   return guest->GetRenderWidgetHostView();
 }
 
 }  // namespace
 
-// These are not documented, so use only after checking -respondsToSelector:.
-@interface NSApplication (UndocumentedSpeechMethods)
-- (void)speakString:(NSString*)string;
-- (void)stopSpeaking:(id)sender;
-- (BOOL)isSpeaking;
-@end
-
 // Private methods:
 @interface RenderWidgetHostViewCocoa ()
 @property(nonatomic, assign) NSRange selectedRange;
 @property(nonatomic, assign) NSRange markedRange;
 
 + (BOOL)shouldAutohideCursorForEvent:(NSEvent*)event;
 - (id)initWithRenderWidgetHostViewMac:(RenderWidgetHostViewMac*)r;
 - (void)processedWheelEvent:(const blink::WebMouseWheelEvent&)event
                    consumed:(BOOL)consumed;
 - (void)processedGestureScrollEvent:(const blink::WebGestureEvent&)event
@@ skipping 541 matching lines @@
 
   if (!display_link_->GetVSyncParameters(&vsync_timebase_, &vsync_interval_)) {
     vsync_timebase_ = base::TimeTicks();
     vsync_interval_ = base::TimeDelta();
     return;
   }
 
   browser_compositor_->UpdateVSyncParameters(vsync_timebase_, vsync_interval_);
 }
 
-void RenderWidgetHostViewMac::SpeakText(const std::string& text) {
-  [NSApp speakString:base::SysUTF8ToNSString(text)];
-}
-
 RenderWidgetHostViewBase*
     RenderWidgetHostViewMac::GetFocusedViewForTextSelection() {
   // We obtain the TextSelection from focused RWH which is obtained from the
   // frame tree. BrowserPlugin-based guests' RWH is not part of the frame tree
   // and the focused RWH will be that of the embedder which is incorrect. In
   // this case we should use TextSelection for |this| since RWHV for guest
   // forwards text selection information to its platform view.
   return is_guest_view_hack_ ? this : GetFocusedWidget()
                                           ? GetFocusedWidget()->GetView()
                                           : nullptr;
@@ skipping 366 matching lines @@
     // set it again every single time the mouse moves.
     base::string16 display_text = tooltip_text_;
     if (tooltip_text_.length() > kMaxTooltipLength)
       display_text = tooltip_text_.substr(0, kMaxTooltipLength);
 
     NSString* tooltip_nsstring = base::SysUTF16ToNSString(display_text);
     [cocoa_view_ setToolTipAtMousePoint:tooltip_nsstring];
   }
 }
 
-bool RenderWidgetHostViewMac::SupportsSpeech() const {
-  return [NSApp respondsToSelector:@selector(speakString:)] &&
-         [NSApp respondsToSelector:@selector(stopSpeaking:)];
-}
-
 void RenderWidgetHostViewMac::SpeakSelection() {
   if (![NSApp respondsToSelector:@selector(speakString:)])
     return;
 
   if (selected_text_.empty() && render_widget_host_) {
     // If there's no selection, speak all text. Send an asynchronous IPC
     // request for fetching all the text for a webcontent.
     // ViewMsg_GetRenderedTextCompleted is sent back to IPC Message receiver.
     render_widget_host_->Send(new ViewMsg_GetRenderedText(
         render_widget_host_->GetRoutingID()));
     return;
   }
 
-  SpeakText(selected_text_);
-}
-
-bool RenderWidgetHostViewMac::IsSpeaking() const {
-  return [NSApp respondsToSelector:@selector(isSpeaking)] &&
-         [NSApp isSpeaking];
-}
-
-void RenderWidgetHostViewMac::StopSpeaking() {
-  if ([NSApp respondsToSelector:@selector(stopSpeaking:)])
-    [NSApp stopSpeaking:cocoa_view_];
+  ui::TextServicesContextMenu::SpeakText(base::UTF8ToUTF16(selected_text_));

[tapted, 2016/12/13 05:11:22]

Can we make |selected_text_| a string16?

It looks like it's just RenderWidgetHostViewMac::OnTextSelectionChanged that
sets it, and it's doing base::UTF16ToUTF8

of course RenderViewImpl::OnGetRenderedText() and
ViewMsg_GetRenderedTextCompleted should also change to string16 :/. But that's
IPC stuff - maybe better for a follow-up. [see next comment]

[spqchan, 2016/12/15 23:29:00]

Added a TODO

 }
 
 //
 // RenderWidgetHostViewCocoa uses the stored selection text,
 // which implements NSServicesRequests protocol.
 //
 
 void RenderWidgetHostViewMac::SetShowingContextMenu(bool showing) {
   RenderWidgetHostViewBase::SetShowingContextMenu(showing);
 
@@ skipping 533 matching lines @@
     else
       DisablePasswordInput();
   } else {
     if (GetTextInputType() == ui::TEXT_INPUT_TYPE_PASSWORD)
       DisablePasswordInput();
   }
 }
 
 void RenderWidgetHostViewMac::OnGetRenderedTextCompleted(
     const std::string& text) {
-  SpeakText(text);
+  ui::TextServicesContextMenu::SpeakText(base::UTF8ToUTF16(text));

[tapted, 2016/12/13 05:11:22]

i.e. Ideally this uses string16 as well, but maybe just a TODO() comment above
to update RenderViewImpl::OnGetRenderedText and the IPC message to use string16

[spqchan, 2016/12/15 23:29:00]

Acknowledged.

 }
 
 void RenderWidgetHostViewMac::PauseForPendingResizeOrRepaintsAndDraw() {
   if (!render_widget_host_ || render_widget_host_->is_hidden())
     return;
 
   // Pausing for one view prevents others from receiving frames.
   // This may lead to large delays, causing overlaps. See crbug.com/352020.
   if (!allow_pause_for_resize_or_repaint_)
     return;
@@ skipping 1046 matching lines @@
     if (known)
       return valid;
   }
 
   SEL action = [item action];
   BOOL is_render_view =
       RenderViewHost::From(renderWidgetHostView_->render_widget_host_) !=
       nullptr;
 
   if (action == @selector(stopSpeaking:))
-    return is_render_view && renderWidgetHostView_->IsSpeaking();
+    return is_render_view;

[tapted, 2016/12/13 05:11:22]

can we do something like && ui::TextServicesContextMenu::IsSpeaking() here? I
think this is needed for the mainMenu to match the context menu.

[spqchan, 2016/12/15 23:29:00]

Whoops, thanks for the catch

 
   if (action == @selector(startSpeaking:))
-    return is_render_view && renderWidgetHostView_->SupportsSpeech();
+    return is_render_view;
 
   // For now, these actions are always enabled for render view,
   // this is sub-optimal.
   // TODO(suzhe): Plumb the "can*" methods up from WebCore.
   if (action == @selector(undo:) ||
       action == @selector(redo:) ||
       action == @selector(cut:) ||
       action == @selector(copy:) ||
       action == @selector(copyToFindPboard:) ||
       action == @selector(paste:) ||
@@ skipping 572 matching lines @@
       renderWidgetHostView_->render_widget_host_->delegate();
   if (render_widget_host_delegate)
     render_widget_host_delegate->SelectAll();
 }
 
 - (void)startSpeaking:(id)sender {
   GetRenderWidgetHostViewToUse(renderWidgetHostView_.get())->SpeakSelection();
 }
 
 - (void)stopSpeaking:(id)sender {
-  GetRenderWidgetHostViewToUse(renderWidgetHostView_.get())->StopSpeaking();
+  ui::TextServicesContextMenu::StopSpeaking();
 }
 
 - (void)cancelComposition {
   if (!hasMarkedText_)
     return;
 
   NSTextInputContext* inputContext = [self inputContext];
   [inputContext discardMarkedText];
 
   hasMarkedText_ = NO;
@@ skipping 84 matching lines @@
 
 // "-webkit-app-region: drag | no-drag" is implemented on Mac by excluding
 // regions that are not draggable. (See ControlRegionView in
 // native_app_window_cocoa.mm). This requires the render host view to be
 // draggable by default.
 - (BOOL)mouseDownCanMoveWindow {
   return YES;
 }
 
 @end