third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.idl - Issue 2164473002: ImageCapture: wire PhotoCapabilities' ISO, width, height and PhotoSettings' width and height

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.idl

Issue 2164473002: ImageCapture: wire PhotoCapabilities' ISO, width, height and PhotoSettings' width and height (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: dcheng@ comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.cpp ('k') | third_party/WebKit/Source/modules/imagecapture/PhotoSettings.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.idl

diff --git a/third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.idl b/third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.idl

index 0b59ae3359db3d62a6a9f51f7fa3380b3555b37a..0519f2eadd8c0a58b1842e296fe4475caf514de6 100644

--- a/third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.idl

+++ b/third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.idl

@@ -13,6 +13,14 @@ enum FocusMode {

[

RuntimeEnabled=ImageCapture,

] interface PhotoCapabilities {

+ // TODO(mcasas): Update the Spec where these members are not readonly.

+ // https://github.com/w3c/mediacapture-image/issues/29

+ readonly attribute MediaSettingsRange iso;

+ // TODO(mcasas): Replace these two with supported and current resolutions.

+ // https://github.com/w3c/mediacapture-image/issues/30

+ readonly attribute MediaSettingsRange imageHeight;

+ readonly attribute MediaSettingsRange imageWidth;

readonly attribute MediaSettingsRange zoom;

readonly attribute FocusMode focusMode;

// TODO(mcasas): Implement all other PhotoCapabilities fields