media/mojo/interfaces/image_capture.mojom - Issue 2164473002: ImageCapture: wire PhotoCapabilities' ISO, width, height and PhotoSettings' width and height

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mojo/interfaces/image_capture.mojom

Issue 2164473002: ImageCapture: wire PhotoCapabilities' ISO, width, height and PhotoSettings' width and height (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: dcheng@ comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « media/capture/video/fake_video_capture_device_unittest.cc ('k') | third_party/WebKit/LayoutTests/imagecapture/getphotocapabilities.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/mojo/interfaces/image_capture.mojom

diff --git a/media/mojo/interfaces/image_capture.mojom b/media/mojo/interfaces/image_capture.mojom

index 3546651c15790a962036d62999b5fdaa55d77dd8..d103ee1555ff127d282834f1ade0fc7a1849fffe 100644

--- a/media/mojo/interfaces/image_capture.mojom

+++ b/media/mojo/interfaces/image_capture.mojom

@@ -19,6 +19,9 @@ enum FocusMode { UNAVAILABLE, AUTO, MANUAL };

// Equivalent to idl PhotoCapabilities,

// https://w3c.github.io/mediacapture-image/#photocapabilities

struct PhotoCapabilities {

+ Range iso;

+ Range height;

+ Range width;

Range zoom;

FocusMode focus_mode;

};

@@ -29,6 +32,10 @@ struct PhotoSettings {

// uint32 cannot be nullable, i.e. uint32? does not work, use instead a flag.

bool has_zoom;

uint32 zoom;

+ bool has_width;

+ uint32 width;

+ bool has_height;

+ uint32 height;

};

// |source_id| is the renderer-side UUID identifier of the image capture device.