media/capture/video/fake_video_capture_device.cc - Issue 2164473002: ImageCapture: wire PhotoCapabilities' ISO, width, height and PhotoSettings' width and height

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/capture/video/fake_video_capture_device.cc

Issue 2164473002: ImageCapture: wire PhotoCapabilities' ISO, width, height and PhotoSettings' width and height (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: dcheng@ comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « media/capture/video/android/video_capture_device_android.cc ('k') | media/capture/video/fake_video_capture_device_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/capture/video/fake_video_capture_device.cc

diff --git a/media/capture/video/fake_video_capture_device.cc b/media/capture/video/fake_video_capture_device.cc

index d163adffb6a176d6dd1cfe82be172ba329489222..3292d75fcbe470096d8cf747e2accb2fa125a762 100644

--- a/media/capture/video/fake_video_capture_device.cc

+++ b/media/capture/video/fake_video_capture_device.cc

@@ -181,6 +181,19 @@ void FakeVideoCaptureDevice::GetPhotoCapabilities(

GetPhotoCapabilitiesCallback callback) {

mojom::PhotoCapabilitiesPtr photo_capabilities =

mojom::PhotoCapabilities::New();

+ photo_capabilities->iso = mojom::Range::New();

+ photo_capabilities->iso->current = 100;

+ photo_capabilities->iso->max = 100;

+ photo_capabilities->iso->min = 100;

+ photo_capabilities->height = mojom::Range::New();

+ photo_capabilities->height->current = capture_format_.frame_size.height();

+ photo_capabilities->height->max = 1080;

+ photo_capabilities->height->min = 240;

+ photo_capabilities->width = mojom::Range::New();

+ photo_capabilities->width->current = capture_format_.frame_size.width();

+ photo_capabilities->width->max = 1920;

+ photo_capabilities->width->min = 320;

+ photo_capabilities->focus_mode = mojom::FocusMode::UNAVAILABLE;

photo_capabilities->zoom = mojom::Range::New();

photo_capabilities->zoom->current = current_zoom_;

photo_capabilities->zoom->max = kMaxZoom;