ImageCapture: wire PhotoCapabilities' ISO, width, height and PhotoSettings' width and height

third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/imagecapture/PhotoCapabilities.h"
 
 namespace blink {
 
 // static
 PhotoCapabilities* PhotoCapabilities::create()
 {
     return new PhotoCapabilities();
 }
 
+MediaSettingsRange* PhotoCapabilities::iso() const { return m_iso; }

[dcheng, 2016/07/22 04:45:29]

FWIW, simple setters and getters are usually inlined into the header in Blink.

[mcasas, 2016/07/22 16:46:32]

I think peter@ mentioned a while ago that I should
try and keep all accesors/mutators together, and,
given the focusMode(), they're all pushed here. WDYT?

[dcheng, 2016/07/22 18:07:23]

The inlining isn't for organization; it's for codegen.

It's not a hard rule, but it is the convention throughout basically the rest of
the codebase. I don't see a reason not to follow it here.

[mcasas, 2016/07/22 23:16:27]

Done.

+
+void PhotoCapabilities::setIso(MediaSettingsRange* value) { m_iso = value; }
+
+MediaSettingsRange* PhotoCapabilities::imageHeight() const { return m_imageHeight; }
+
+void PhotoCapabilities::setImageHeight(MediaSettingsRange* value) { m_imageHeight = value; }
+
+MediaSettingsRange* PhotoCapabilities::imageWidth() const { return m_imageWidth; }
+
+void PhotoCapabilities::setImageWidth(MediaSettingsRange* value) { m_imageWidth = value; }
+
 MediaSettingsRange* PhotoCapabilities::zoom() const { return m_zoom; }
 
 void PhotoCapabilities::setZoom(MediaSettingsRange* value) { m_zoom = value; }
 
 String PhotoCapabilities::focusMode() const
 {
     switch (m_focusMode) {
     case media::mojom::blink::FocusMode::UNAVAILABLE:
         return "unavailable";
     case media::mojom::blink::FocusMode::AUTO:
         return "auto";
     case media::mojom::blink::FocusMode::MANUAL:
         return "manual";
     default:
         NOTREACHED();
     }
     return emptyString();
 }
 
 void PhotoCapabilities::setFocusMode(media::mojom::blink::FocusMode focusMode)
 {
     m_focusMode = focusMode;
 }
 
 DEFINE_TRACE(PhotoCapabilities)
 {
+    visitor->trace(m_iso);
+    visitor->trace(m_imageHeight);
+    visitor->trace(m_imageWidth);
     visitor->trace(m_zoom);
 }
 
 } // namespace blink