Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2164453003: GN: polyfill is_fuchsia (Closed)

Created:
4 years, 5 months ago by mtklein_C
Modified:
4 years, 5 months ago
Reviewers:
abarth, jcgregorio
CC:
abarth-chromium, reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: polyfill is_fuchsia I'll tell you what, I need to practice typing fuchsia out a few hundred times... I managed to spell it three different ways in this CL. Plus, gn format BUILD.gn BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2164453003 Committed: https://skia.googlesource.com/skia/+/e817ddf9b32200ebfd216921d172ef1342e13cae

Patch Set 1 #

Patch Set 2 : fmt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M BUILD.gn View 1 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
mtklein_C
4 years, 5 months ago (2016-07-19 12:16:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164453003/20001
4 years, 5 months ago (2016-07-19 12:16:56 UTC) #6
jcgregorio
lgtm
4 years, 5 months ago (2016-07-19 13:01:10 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/e817ddf9b32200ebfd216921d172ef1342e13cae
4 years, 5 months ago (2016-07-19 13:03:26 UTC) #9
abarth
4 years, 5 months ago (2016-07-19 14:28:58 UTC) #11
Message was sent while issue was closed.
LGTM

Thanks!

Powered by Google App Engine
This is Rietveld 408576698