Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 216443005: Reapply "Media Galleries API Metadata: Image metadata" (Closed)

Created:
6 years, 8 months ago by tommycli
Modified:
6 years, 8 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, oshima+watch_chromium.org, dyu1, vandebo (ex-Chrome), grt+watch_chromium.org, tommycli, anantha, Greg Billock, dennis_jeffrey, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org
Visibility:
Public.

Description

Reapply "Media Galleries API Metadata: Image metadata" Original patch (also PS1) https://codereview.chromium.org/191583002 CQ can't catch the breakages of this patch. TBR= BUG=318450 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261864

Patch Set 1 : original patch #

Patch Set 2 : fix expected_deps #

Patch Set 3 : add libexif.dylib to some isolate files #

Patch Set 4 : merge origin/master #

Total comments: 1

Patch Set 5 : merge origin/master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+605 lines, -19 lines) Patch
M build/common.gypi View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 2 3 4 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/chrome.isolate View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/chrome_dll_bundle.gypi View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/media_galleries.idl View 1 2 3 4 1 chunk +14 lines, -1 line 0 comments Download
M chrome/installer/linux/debian/expected_deps View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/linux/rpm/expected_deps_i386 View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/linux/rpm/expected_deps_x86_64 View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/linux/sysroot_scripts/packagelist.debian.wheezy.amd64 View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/installer/mini_installer/chrome.release View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/interactive_ui_tests.isolate View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/sync_integration_tests.isolate View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/media_galleries/media_metadata/test.js View 1 2 3 4 2 chunks +23 lines, -1 line 0 comments Download
M chrome/tools/build/chromeos/FILES.cfg View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/tools/build/mac/TESTS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/tools/build/mac/dump_product_syms View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/unit_tests.isolate View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
A chrome/utility/media_galleries/image_metadata_extractor.h View 1 chunk +84 lines, -0 lines 0 comments Download
A chrome/utility/media_galleries/image_metadata_extractor.cc View 1 chunk +279 lines, -0 lines 0 comments Download
A chrome/utility/media_galleries/image_metadata_extractor_unittest.cc View 1 chunk +66 lines, -0 lines 0 comments Download
M chrome/utility/media_galleries/media_metadata_parser.cc View 1 2 3 4 5 chunks +57 lines, -0 lines 0 comments Download
M content/content_browsertests.isolate View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/libexif/libexif.gyp View 3 chunks +28 lines, -15 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
tommycli
ccameron: I think this will fix the issues that broke the build before, but I'm ...
6 years, 8 months ago (2014-04-01 21:11:27 UTC) #1
tommycli
6 years, 8 months ago (2014-04-01 21:20:16 UTC) #2
Lei Zhang
lgtm
6 years, 8 months ago (2014-04-01 21:22:57 UTC) #3
ccameron
On 2014/04/01 21:22:57, Lei Zhang wrote: > lgtm lgtm, go for it -- I'm watching ...
6 years, 8 months ago (2014-04-01 21:28:22 UTC) #4
tommycli
The CQ bit was checked by tommycli@chromium.org
6 years, 8 months ago (2014-04-01 21:34:27 UTC) #5
tommycli
The CQ bit was unchecked by tommycli@chromium.org
6 years, 8 months ago (2014-04-01 22:10:03 UTC) #6
tommycli
The CQ bit was checked by tommycli@chromium.org
6 years, 8 months ago (2014-04-01 22:10:09 UTC) #7
tommycli
The CQ bit was checked by tommycli@chromium.org
6 years, 8 months ago (2014-04-01 22:28:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommycli@chromium.org/216443005/40001
6 years, 8 months ago (2014-04-01 22:54:48 UTC) #9
tommycli
The CQ bit was unchecked by tommycli@chromium.org
6 years, 8 months ago (2014-04-01 23:11:18 UTC) #10
grt (UTC plus 2)
https://codereview.chromium.org/216443005/diff/60001/third_party/libexif/libexif.gyp File third_party/libexif/libexif.gyp (right): https://codereview.chromium.org/216443005/diff/60001/third_party/libexif/libexif.gyp#newcode23 third_party/libexif/libexif.gyp:23: 'type': 'shared_library', does this need to be built as ...
6 years, 8 months ago (2014-04-02 17:03:58 UTC) #11
Lei Zhang
On 2014/04/02 17:03:58, grt wrote: > https://codereview.chromium.org/216443005/diff/60001/third_party/libexif/libexif.gyp > File third_party/libexif/libexif.gyp (right): > > https://codereview.chromium.org/216443005/diff/60001/third_party/libexif/libexif.gyp#newcode23 > ...
6 years, 8 months ago (2014-04-02 21:04:52 UTC) #12
grt (UTC plus 2)
On 2014/04/02 21:04:52, Lei Zhang wrote: > On 2014/04/02 17:03:58, grt wrote: > > > ...
6 years, 8 months ago (2014-04-02 21:49:39 UTC) #13
Lei Zhang
On 2014/04/02 21:49:39, grt wrote: > Ah, okay. Lgtm for the chrome/installer changes. If you ...
6 years, 8 months ago (2014-04-02 21:52:17 UTC) #14
tommycli
The CQ bit was checked by tommycli@chromium.org
6 years, 8 months ago (2014-04-04 16:23:33 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommycli@chromium.org/216443005/80001
6 years, 8 months ago (2014-04-04 16:23:49 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-04 18:29:47 UTC) #17
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) chrome_elf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=91550
6 years, 8 months ago (2014-04-04 18:29:47 UTC) #18
tommycli
The CQ bit was checked by tommycli@chromium.org
6 years, 8 months ago (2014-04-04 18:31:04 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommycli@chromium.org/216443005/80001
6 years, 8 months ago (2014-04-04 18:31:54 UTC) #20
commit-bot: I haz the power
Change committed as 261864
6 years, 8 months ago (2014-04-04 20:59:00 UTC) #21
tommycli
6 years, 8 months ago (2014-04-04 21:50:32 UTC) #22
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/225023014/ by tommycli@chromium.org.

The reason for reverting is: Breaking Mac 10.6 release testers. (no idea why,
but it is).

Powered by Google App Engine
This is Rietveld 408576698