Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2164423002: Fix a ConcurrentModificationException issue (Closed)

Created:
4 years, 5 months ago by qinmin
Modified:
4 years, 5 months ago
Reviewers:
michaelbai
CC:
chromium-reviews, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a ConcurrentModificationException issue Shouldn't remove items from a hashmap while iterating it. Instead, use an iterator and call iterator.remove(). BUG=630218 Committed: https://crrev.com/4106f1c294c9a4e90e273d1600b302f28f9dd9a4 Cr-Commit-Position: refs/heads/master@{#406958}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java View 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
qinmin
PTAL
4 years, 5 months ago (2016-07-21 20:02:16 UTC) #2
michaelbai
lgtm
4 years, 5 months ago (2016-07-21 20:06:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164423002/1
4 years, 5 months ago (2016-07-21 20:39:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 21:49:04 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 21:50:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4106f1c294c9a4e90e273d1600b302f28f9dd9a4
Cr-Commit-Position: refs/heads/master@{#406958}

Powered by Google App Engine
This is Rietveld 408576698