Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2164383002: Speculative fix for timeouts (hangs) in (Closed)

Created:
4 years, 5 months ago by rmacnak
Modified:
4 years, 5 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Speculative fix for timeouts (hangs) in language/disassmble_test utils/recursive_import_test utils/dummy_compiler_test Also fix an ASAN warning about mismatched new/delete. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/35f56623d44ecc60f3796fe180888929a266f341

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M runtime/bin/main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/pages.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
4 years, 5 months ago (2016-07-21 18:12:33 UTC) #2
Florian Schneider
Lgtm. Was there a bug number for these?
4 years, 5 months ago (2016-07-21 18:20:03 UTC) #3
rmacnak
On 2016/07/21 18:20:03, Florian Schneider wrote: > Lgtm. > > Was there a bug number ...
4 years, 5 months ago (2016-07-21 18:22:16 UTC) #4
rmacnak
4 years, 5 months ago (2016-07-21 18:25:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
35f56623d44ecc60f3796fe180888929a266f341 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698