Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Issue 2164373002: [turbolizer] Style improvements. (Closed)

Created:
4 years, 5 months ago by bgeron
Modified:
4 years, 5 months ago
Reviewers:
danno
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@t-p3-base
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbolizer] Style improvements. - Remove duplicated CSS. - Expand landing area of upload button. - Give the toolbox a transparent white background. - Make the phase-select box look nicer before file load. - Remove the margin at the top of the screen. The height of the margin was exactly the height of span#graph-toolbox, and due to the semantics of position:relative, space was reserved for it at the top of div#middle. BUG= R=danno Committed: https://crrev.com/7ef24ad99c4d2bf65bca3782ad9a22a272dc3cf4 Cr-Commit-Position: refs/heads/master@{#38003}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -37 lines) Patch
M tools/turbolizer/index.html View 1 chunk +23 lines, -18 lines 0 comments Download
M tools/turbolizer/turbo-visualizer.css View 2 chunks +9 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bgeron
Please take a look. I'm OOO on Friday, so discussing would best work on a ...
4 years, 5 months ago (2016-07-21 18:17:07 UTC) #1
danno
lgtm
4 years, 5 months ago (2016-07-22 12:49:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164373002/1
4 years, 5 months ago (2016-07-25 09:27:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 09:48:41 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 09:50:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ef24ad99c4d2bf65bca3782ad9a22a272dc3cf4
Cr-Commit-Position: refs/heads/master@{#38003}

Powered by Google App Engine
This is Rietveld 408576698