Add SkColorSpace to GrDrawContext

src/effects/SkXfermodeImageFilter.cpp

 /*
  * Copyright 2013 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkXfermodeImageFilter.h"
 
 #include "SkCanvas.h"
@@ skipping 222 matching lines @@
 
         // A null 'xferFP' here means kSrc_Mode was used in which case we can just proceed
         if (xferFP) {
             paint.addColorFragmentProcessor(std::move(xferFP));
         }
     } else {
         paint.addColorFragmentProcessor(std::move(bgFP));
     }
 
     paint.setPorterDuffXPFactory(SkXfermode::kSrc_Mode);
 

[robertphillips, 2016/07/21 19:22:41]

What if foreground & background have different color spaces ?

source is probably the correct answer here.

[Brian Osman, 2016/07/21 19:51:44]

Yes. Output should be in color space of source. I'll be plumbing
colorspace of FG/BG to the FP for this draw, so we convert both
to the destination space before combining them.

     sk_sp<GrDrawContext> drawContext(context->newDrawContext(SkBackingFit::kApprox,
                                                              bounds.width(), bounds.height(),
-                                                             kSkia8888_GrPixelConfig));
+                                                             kSkia8888_GrPixelConfig,
+                                                             sk_ref_sp(source->getColorSpace())));
     if (!drawContext) {
         return nullptr;
     }
 
     SkMatrix matrix;
     matrix.setTranslate(SkIntToScalar(-bounds.left()), SkIntToScalar(-bounds.top()));
     drawContext->drawRect(GrNoClip(), paint, matrix, SkRect::Make(bounds));
 
-    // TODO: Get the colorSpace from the drawContext (once it has one)
     return SkSpecialImage::MakeFromGpu(SkIRect::MakeWH(bounds.width(), bounds.height()),
                                        kNeedNewImageUniqueID_SpecialImage,
                                        drawContext->asTexture(),
-                                       sk_ref_sp(source->getColorSpace()));
+                                       sk_ref_sp(drawContext->getColorSpace()));
 }
 
 #endif