|
Revert 260147 "Handling LevelDB errors encountered after open."
The browser test is showing Mac ASAN failures.
> Handling LevelDB errors encountered after open.
>
> The previous IndexedDB implementation only checked for (and reported)
> corrupted LevelDB's during open. If they are determined to be corrupted
> during use then the database was simply closed. The page would be unaware of
> this, and would likely reopen the database at a later time (which would work)
> only to fail again during a read/write operation. There was no way for the
> page to get out of that corrupted state - the user would have to delete all
> origin data.
>
> This change will record the fact that the backing store was corrupted, and
> during open this would be read and, if present, result in the same dataLoss
> state being reported to the page in the upgradeneeded event.
>
> Also split IndexedDBBackingStore's REPORT_ERROR macro in two:
> REPORT_ERROR_UNTESTED (which calls NOTREACHED) and REPORT_ERROR. REPORT_ERROR
> is used for errors which are encountered during tests. This was done so that
> runtime errors could still be caught during a debug build run.
>
> BUG= 322707
> R=isherman@chromium.org, jochen@chromium.org, jsbell@chromium.org
>
> Review URL: https://codereview.chromium.org/197333009
>
> Patch from Christopher Mumford < cmumford@chromium.org>.
TBR=jsbell@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260209
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+118 lines, -614 lines) |
Patch |
 |
M |
trunk/src/content/browser/indexed_db/indexed_db_backing_store.h
|
View
|
|
4 chunks |
+0 lines, -11 lines |
0 comments
|
Download
|
 |
M |
trunk/src/content/browser/indexed_db/indexed_db_backing_store.cc
|
View
|
|
57 chunks |
+79 lines, -203 lines |
0 comments
|
Download
|
 |
M |
trunk/src/content/browser/indexed_db/indexed_db_browsertest.cc
|
View
|
|
4 chunks |
+0 lines, -134 lines |
0 comments
|
Download
|
 |
M |
trunk/src/content/browser/indexed_db/indexed_db_database.cc
|
View
|
|
11 chunks |
+33 lines, -70 lines |
0 comments
|
Download
|
 |
M |
trunk/src/content/browser/indexed_db/indexed_db_factory.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
trunk/src/content/browser/indexed_db/indexed_db_factory.cc
|
View
|
|
2 chunks |
+0 lines, -19 lines |
0 comments
|
Download
|
 |
M |
trunk/src/content/browser/indexed_db/indexed_db_transaction.cc
|
View
|
|
1 chunk |
+4 lines, -3 lines |
0 comments
|
Download
|
 |
M |
trunk/src/content/browser/indexed_db/leveldb/leveldb_database.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
trunk/src/content/browser/indexed_db/leveldb/leveldb_database.cc
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
trunk/src/content/test/data/indexeddb/common.js
|
View
|
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
 |
D |
trunk/src/content/test/data/indexeddb/corrupted_open_db_detection.html
|
View
|
|
1 chunk |
+0 lines, -114 lines |
0 comments
|
Download
|
 |
D |
trunk/src/content/test/data/indexeddb/corrupted_open_db_recovery.html
|
View
|
|
1 chunk |
+0 lines, -46 lines |
0 comments
|
Download
|
 |
M |
trunk/src/tools/metrics/histograms/histograms.xml
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|