Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2164273002: V8. ASM-2-WASM. Enforces source code layout. (Closed)

Created:
4 years, 5 months ago by John
Modified:
4 years, 5 months ago
Reviewers:
bradnelson, aseemgarg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

V8. ASM-2-WASM. Enforces source code layout. BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=628450 BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 TEST= cctest/asmjs/test-asm-typer.cc TEST= mjsunit/wasm/* LOG= N Committed: https://crrev.com/d50998c48015b4fccd564b84a26c99069e3c6b21 Cr-Commit-Position: refs/heads/master@{#37950}

Patch Set 1 #

Patch Set 2 : Ensures that absent sections never overlap. #

Patch Set 3 : Adds new entry to the new cctests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -0 lines) Patch
M src/asmjs/asm-typer.cc View 1 7 chunks +92 lines, -0 lines 0 comments Download
M test/cctest/asmjs/test-asm-typer.cc View 1 2 1 chunk +109 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
John
4 years, 5 months ago (2016-07-21 15:01:50 UTC) #11
bradnelson
lgtm
4 years, 5 months ago (2016-07-21 15:30:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164273002/40001
4 years, 5 months ago (2016-07-21 15:30:12 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-21 15:32:13 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 15:34:44 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d50998c48015b4fccd564b84a26c99069e3c6b21
Cr-Commit-Position: refs/heads/master@{#37950}

Powered by Google App Engine
This is Rietveld 408576698