Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2164263003: [turbofan] Induction variable bound analysis. (Closed)

Created:
4 years, 5 months ago by Jarin
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Induction variable bound analysis. The new phase will detect loop variable, infer bounds and bake them into the type. Committed: https://crrev.com/398a114357dc3d64025fddf9645a1eb5cebcb1ca Cr-Commit-Position: refs/heads/master@{#38077}

Patch Set 1 #

Patch Set 2 : Tweaks #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+684 lines, -32 lines) Patch
M BUILD.gn View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/common-operator.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/common-operator.cc View 1 2 3 chunks +38 lines, -0 lines 0 comments Download
M src/compiler/loop-analysis.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/loop-peeling.cc View 2 chunks +3 lines, -2 lines 0 comments Download
A src/compiler/loop-variable-optimizer.h View 1 chunk +112 lines, -0 lines 0 comments Download
A src/compiler/loop-variable-optimizer.cc View 1 chunk +390 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 2 1 chunk +18 lines, -17 lines 0 comments Download
M src/compiler/pipeline.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M src/compiler/typer.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/compiler/typer.cc View 1 2 7 chunks +101 lines, -10 lines 0 comments Download
M src/compiler/verifier.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M src/v8.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Jarin
Here is the preview of the induction variable typer. Could you take a look, please? ...
4 years, 5 months ago (2016-07-21 18:14:14 UTC) #2
Benedikt Meurer
Nice, LGTM.
4 years, 4 months ago (2016-07-27 05:12:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164263003/40001
4 years, 4 months ago (2016-07-27 05:13:20 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-07-27 05:50:43 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 05:51:12 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/398a114357dc3d64025fddf9645a1eb5cebcb1ca
Cr-Commit-Position: refs/heads/master@{#38077}

Powered by Google App Engine
This is Rietveld 408576698