Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 2164263002: Roll buildtools for latest GN binary. (Closed)

Created:
4 years, 5 months ago by mtklein_C
Modified:
4 years, 5 months ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Roll buildtools for latest GN binary. This GN binary has a JSON backend that's meant to be parsed to seed other build configurations (e.g. CMake, Android, Google3). You will need to re-run ./gn.py to fetch the newest binary. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2164263002 Committed: https://skia.googlesource.com/skia/+/9b43094bf207ff3e7ac61b769c0f306395761b4c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
mtklein_C
4 years, 5 months ago (2016-07-21 11:47:52 UTC) #3
jcgregorio
lgtm
4 years, 5 months ago (2016-07-21 12:36:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164263002/1
4 years, 5 months ago (2016-07-21 13:07:28 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 13:29:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9b43094bf207ff3e7ac61b769c0f306395761b4c

Powered by Google App Engine
This is Rietveld 408576698