third_party/WebKit/LayoutTests/svg/animations/animation-started-use-counter.html - Issue 2164233002: Use-count when SMIL animation renders a frame

Side by Side Diff: third_party/WebKit/LayoutTests/svg/animations/animation-started-use-counter.html

Issue 2164233002: Use-count when SMIL animation renders a frame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@smil-use-counters

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <svg width="400" height="400">

	5 <rect id="target" x="10" y="10" width="80" height="80">

	6 </rect>

	7 </svg>

	8 <script>

	9 'use strict';

	10

	11 // From UseCounter.h

	12 var SVGSMILAnimationAppliedEffect = 1458;

	13

	14 var testHandle = async_test("Count when SMIL animation has rendered a frame");
	fs 2016/07/21 10:17:32 Maybe s/rendered a frame/been applied/ to more clo Maybe s/rendered a frame/been applied/ to more closely match counter name (and location?) suzyh_UTC10 (ex-contributor) 2016/07/25 03:16:00 Done. Show quoted text On 2016/07/21 at 10:17:32, fs (OoO until Aug 15) wrote: > Maybe s/rendered a frame/been applied/ to more closely match counter name (and location?) Done.
	15

	16 requestAnimationFrame(function() {
	fs 2016/07/21 10:17:32 Optionally I think you could pause the timeline (S Optionally I think you could pause the timeline (SVGSVGElement.pauseAnimations) and setCurrentTime to something within the relevant interval of the animation element. (Could also specify the <animate> in the markup and give it a suitable interval or use beginElement.) suzyh_UTC10 (ex-contributor) 2016/07/25 03:15:59 I tried the following test, but it crashed in debu Show quoted text On 2016/07/21 at 10:17:32, fs (OoO until Aug 15) wrote: > Optionally I think you could pause the timeline (SVGSVGElement.pauseAnimations) and setCurrentTime to something within the relevant interval of the animation element. (Could also specify the <animate> in the markup and give it a suitable interval or use beginElement.) I tried the following test, but it crashed in debug mode when unpausing the animations, with "ASSERTION FAILED: m_activeState != Active". Have I done something stupid, or is this a bug? <svg id="target" width="400" height="400"> <rect x="10" y="10" width="80" height="80"> <animate attributeType="XML" attributeName="y" from="10" to="200" begin="2", dur="20" /> </rect> </svg> ... test(function() { target.pauseAnimations(); assert_false(internals.isUseCounted(document, SVGSMILAnimationAppliedEffect)); target.setCurrentTime(3); target.unpauseAnimations(); assert_true(internals.isUseCounted(document, SVGSMILAnimationAppliedEffect)); }, ...); fs 2016/07/25 14:50:41 I've hard time seeing that it wouldn't be a bug. C Show quoted text On 2016/07/25 at 03:15:59, suzyh wrote: > On 2016/07/21 at 10:17:32, fs (OoO until Aug 15) wrote: > > Optionally I think you could pause the timeline (SVGSVGElement.pauseAnimations) and setCurrentTime to something within the relevant interval of the animation element. (Could also specify the <animate> in the markup and give it a suitable interval or use beginElement.) > > I tried the following test, but it crashed in debug mode when unpausing the animations, with "ASSERTION FAILED: m_activeState != Active". Have I done something stupid, or is this a bug? I've hard time seeing that it wouldn't be a bug. Could you file one and attach that attempt (or c'n'p your example into the bug?) Show quoted text > <svg id="target" width="400" height="400"> > <rect x="10" y="10" width="80" height="80"> > <animate attributeType="XML" attributeName="y" from="10" to="200" begin="2", dur="20" /> > </rect> > </svg> > ... > test(function() { > target.pauseAnimations(); > assert_false(internals.isUseCounted(document, SVGSMILAnimationAppliedEffect)); > target.setCurrentTime(3); > target.unpauseAnimations(); This call shouldn't be needed (I guess this is what ends up triggering the assert?) so it'd be something like: async_test(t => { target.pauseAnimations(); assert_false(...); target.setCurrentTime(3); window.onload = () => { // 'load' starts the timeline and applies the animations at 3s. setTimeout(t.step_func_done(() => { assert_true(...); }), 0); }); }, ...); but no need to dwell on it really. (I.e the existing test works.) Show quoted text > assert_true(internals.isUseCounted(document, SVGSMILAnimationAppliedEffect)); > }, ...);
	17 requestAnimationFrame(function() {

	18 testHandle.step(function() {

	19 var animation = document.createElementNS("http://www.w3.org/2000/svg ", "animate");

	20 animation.setAttribute("attributeType", "XML");

	21 animation.setAttribute("attributeName", "y");

	22 animation.setAttribute("from", "210");

	23 animation.setAttribute("to", "310");

	24 animation.setAttribute("begin", "-5");

	25 animation.setAttribute("dur", "20");

	26 target.appendChild(animation);

	27 assert_false(internals.isUseCounted(document, SVGSMILAnimationApplie dEffect));

	28 });

	29

	30 requestAnimationFrame(function() {

	31 requestAnimationFrame(function() {

	32 testHandle.step(function() {

	33 assert_true(internals.isUseCounted(document, SVGSMILAnimatio nAppliedEffect));

	34 testHandle.done();

	35 });

	36 });

	37 });

	38 });

	39 });

	40

	41 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp » ('J')