Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1844)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 216423011: Move remained platform tests from web/tests/ to platform/ (Closed)

Created:
6 years, 9 months ago by dshwang
Modified:
6 years, 8 months ago
CC:
blink-reviews, jamesr, krit, jzern, danakj, dsinclair, skal, jbroman, blink-layers+watch_chromium.org, Rik, urvang (Google), vikasa, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move remained platform tests from web/tests/ to platform/ Move GraphicsLayerTest, ImageLayerChromiumTest, OpaqueRectTrackingContentLayerDelegateTest, FilterOperationsTest, ImageFilterBuilderTest, and WEBPImageDecoderTest. BUG=353585 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170681

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1290 lines) Patch
M Source/platform/blink_platform.gypi View 3 chunks +8 lines, -2 lines 0 comments Download
A + Source/platform/graphics/GraphicsLayerTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
A + Source/platform/graphics/ImageLayerChromiumTest.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
A + Source/platform/graphics/OpaqueRectTrackingContentLayerDelegateTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
A + Source/platform/graphics/filters/FilterOperationsTest.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/platform/graphics/filters/ImageFilterBuilderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/image-decoders/webp/WEBPImageDecoderTest.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
D Source/web/tests/FilterOperationsTest.cpp View 1 chunk +0 lines, -61 lines 0 comments Download
D Source/web/tests/GraphicsLayerTest.cpp View 1 chunk +0 lines, -168 lines 0 comments Download
D Source/web/tests/ImageFilterBuilderTest.cpp View 1 chunk +0 lines, -125 lines 0 comments Download
D Source/web/tests/ImageLayerChromiumTest.cpp View 1 chunk +0 lines, -128 lines 0 comments Download
D Source/web/tests/OpaqueRectTrackingContentLayerDelegateTest.cpp View 1 chunk +0 lines, -197 lines 0 comments Download
D Source/web/tests/WEBPImageDecoderTest.cpp View 1 chunk +0 lines, -596 lines 0 comments Download
M Source/web/web.gypi View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
dshwang
could you review please?
6 years, 9 months ago (2014-03-28 19:03:46 UTC) #1
urvang (Google)
lgtm LGTM for WEBPImageDecoderTest
6 years, 9 months ago (2014-03-28 19:11:56 UTC) #2
dshwang
On 2014/03/28 19:11:56, urvang (Google) wrote: > lgtm > > LGTM for WEBPImageDecoderTest Thank you ...
6 years, 8 months ago (2014-03-29 08:34:04 UTC) #3
dshwang
jochen@, could you have a chance to review?
6 years, 8 months ago (2014-04-01 15:36:15 UTC) #4
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-04-02 09:42:59 UTC) #5
dshwang
The CQ bit was checked by dongseong.hwang@intel.com
6 years, 8 months ago (2014-04-02 10:34:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/216423011/1
6 years, 8 months ago (2014-04-02 10:34:22 UTC) #7
dshwang
On 2014/04/02 09:42:59, jochen wrote: > lgtm Thank you for review!
6 years, 8 months ago (2014-04-02 10:34:23 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 11:42:00 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-02 11:42:01 UTC) #10
dshwang
The CQ bit was checked by dongseong.hwang@intel.com
6 years, 8 months ago (2014-04-02 11:56:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/216423011/1
6 years, 8 months ago (2014-04-02 11:57:10 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 13:04:54 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-02 13:04:54 UTC) #14
dshwang
The CQ bit was checked by dongseong.hwang@intel.com
6 years, 8 months ago (2014-04-02 17:08:47 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/216423011/1
6 years, 8 months ago (2014-04-02 17:08:50 UTC) #16
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 19:00:15 UTC) #17
Message was sent while issue was closed. 
Change committed as 170681

Powered by Google App Engine
This is Rietveld 408576698