Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2164223002:
MD Setting: drop changes to background-color on :hover (Closed)
|
Created:
4 years, 5 months ago by Dan Beam Modified:
4 years, 5 months ago Reviewers:
stevenjb CC:
chromium-reviews, dbeam+watch-elements_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, dbeam+watch-settings_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Setting: drop changes to background-color on :hover
R=stevenjb@chromium.org
BUG=630067
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOTRY=true # android bots keep failing, this code doesn't even run on android...
Committed: https://crrev.com/a4710216e29e419a07dd7dd84fd6023c9b2f51ac
Cr-Commit-Position: refs/heads/master@{#407007}
Patch Set 1 #Patch Set 2 : . #
Total comments: 4
Patch Set 3 : stevenjb@ review #
Messages
Total messages: 33 (21 generated)
Description was changed from ========== MD Setting: drop changes to background-color on :hover R=stevenjb@chromium.org BUG=630067 ========== to ========== MD Setting: drop changes to background-color on :hover R=stevenjb@chromium.org BUG=630067 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2164223002/diff/20001/ui/webui/resources/cr_e... File ui/webui/resources/cr_elements/network/cr_network_list_item_css.html (left): https://codereview.chromium.org/2164223002/diff/20001/ui/webui/resources/cr_e... ui/webui/resources/cr_elements/network/cr_network_list_item_css.html:23: } Please leave this one in for now. Focus is a disaster on the network menu. I will address both at the same time.
https://codereview.chromium.org/2164223002/diff/20001/ui/webui/resources/cr_e... File ui/webui/resources/cr_elements/network/cr_network_list_item_css.html (left): https://codereview.chromium.org/2164223002/diff/20001/ui/webui/resources/cr_e... ui/webui/resources/cr_elements/network/cr_network_list_item_css.html:23: } On 2016/07/21 16:00:58, stevenjb wrote: > Please leave this one in for now. Focus is a disaster on the network menu. I > will address both at the same time. this does address focus because right now :hover and :focus will look basically exactly the same
https://codereview.chromium.org/2164223002/diff/20001/ui/webui/resources/cr_e... File ui/webui/resources/cr_elements/network/cr_network_list_item_css.html (left): https://codereview.chromium.org/2164223002/diff/20001/ui/webui/resources/cr_e... ui/webui/resources/cr_elements/network/cr_network_list_item_css.html:23: } On 2016/07/21 17:53:31, Dan Beam wrote: > On 2016/07/21 16:00:58, stevenjb wrote: > > Please leave this one in for now. Focus is a disaster on the network menu. I > > will address both at the same time. > > this does address focus because right now :hover and :focus will look basically > exactly the same I don't follow. All I am saying is that I would prefer not to remove the hover behavior on the network list until the focus behavior is at least reasonable. i.e. please just wait for me to fix this properly.
https://codereview.chromium.org/2164223002/diff/20001/ui/webui/resources/cr_e... File ui/webui/resources/cr_elements/network/cr_network_list_item_css.html (left): https://codereview.chromium.org/2164223002/diff/20001/ui/webui/resources/cr_e... ui/webui/resources/cr_elements/network/cr_network_list_item_css.html:23: } On 2016/07/21 18:22:10, stevenjb wrote: > On 2016/07/21 17:53:31, Dan Beam wrote: > > On 2016/07/21 16:00:58, stevenjb wrote: > > > Please leave this one in for now. Focus is a disaster on the network menu. I > > > will address both at the same time. > > > > this does address focus because right now :hover and :focus will look > basically > > exactly the same > > I don't follow. All I am saying is that I would prefer not to remove the hover > behavior on the network list until the focus behavior is at least reasonable. > i.e. please just wait for me to fix this properly. Done.
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== MD Setting: drop changes to background-color on :hover R=stevenjb@chromium.org BUG=630067 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Setting: drop changes to background-color on :hover R=stevenjb@chromium.org BUG=630067 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NOTRY=true # android bots keep failing, this code doesn't even run on android... ==========
The CQ bit was unchecked by dbeam@chromium.org
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== MD Setting: drop changes to background-color on :hover R=stevenjb@chromium.org BUG=630067 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NOTRY=true # android bots keep failing, this code doesn't even run on android... ========== to ========== MD Setting: drop changes to background-color on :hover R=stevenjb@chromium.org BUG=630067 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NOTRY=true # android bots keep failing, this code doesn't even run on android... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== MD Setting: drop changes to background-color on :hover R=stevenjb@chromium.org BUG=630067 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NOTRY=true # android bots keep failing, this code doesn't even run on android... ========== to ========== MD Setting: drop changes to background-color on :hover R=stevenjb@chromium.org BUG=630067 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NOTRY=true # android bots keep failing, this code doesn't even run on android... Committed: https://crrev.com/a4710216e29e419a07dd7dd84fd6023c9b2f51ac Cr-Commit-Position: refs/heads/master@{#407007} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/a4710216e29e419a07dd7dd84fd6023c9b2f51ac Cr-Commit-Position: refs/heads/master@{#407007} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
