Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 2164213002: cc: Single fullscreen overlay validatator flag. (Closed)

Created:
4 years, 5 months ago by Daniele Castagna
Modified:
4 years, 5 months ago
Reviewers:
reveman, ccameron
CC:
cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, sievers+watch_chromium.org, Ian Vollick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Single fullscreen overlay validatator flag. This CL allows the value of the flag "enable-harware-overlays" to be "single-fullscreen." This makes the compositor use a simple strategy that promotes a quad to an overlay iff the underlaying buffer can be used to replace the main framebuffer. BUG=b/29430506 Committed: https://crrev.com/2a63ea0e74cfa454e1e76e92688ea8e189ec079d Cr-Commit-Position: refs/heads/master@{#406952}

Patch Set 1 #

Patch Set 2 : Make reflector_impl_unittest.cc compile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -9 lines) Patch
M components/display_compositor/compositor_overlay_candidate_validator_ozone.h View 2 chunks +4 lines, -2 lines 0 comments Download
M components/display_compositor/compositor_overlay_candidate_validator_ozone.cc View 3 chunks +13 lines, -5 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/compositor/reflector_impl_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/compositor/compositor_switches.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
Daniele Castagna
4 years, 5 months ago (2016-07-21 01:22:03 UTC) #6
reveman
lgtm
4 years, 5 months ago (2016-07-21 01:26:23 UTC) #7
Daniele Castagna
+chris for ownership
4 years, 5 months ago (2016-07-21 01:42:31 UTC) #11
ccameron
lgtm -- some tests need updating for the extra argument
4 years, 5 months ago (2016-07-21 05:48:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164213002/20001
4 years, 5 months ago (2016-07-21 20:32:46 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 21:36:14 UTC) #20
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 21:37:57 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2a63ea0e74cfa454e1e76e92688ea8e189ec079d
Cr-Commit-Position: refs/heads/master@{#406952}

Powered by Google App Engine
This is Rietveld 408576698