Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2164193002: Initial SVG model (Closed)

Created:
4 years, 5 months ago by f(malita)
Modified:
4 years, 4 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Initial SVG model A minimal subset needed to render tiger.svg: <svg>, <g>, <path>, 'd', 'fill'/'stroke' (color-only), 'transform'. R=reed@google.com,robertphillips@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2164193002 Committed: https://skia.googlesource.com/skia/+/6ceef3dd67617c5f4572ada98d5ee85777d2db99

Patch Set 1 #

Patch Set 2 : WIP #

Patch Set 3 : WIP #

Patch Set 4 : WIP #

Patch Set 5 : WIP #

Patch Set 6 : WIP #

Patch Set 7 : svgDir #

Total comments: 2

Patch Set 8 : review #

Patch Set 9 : warning fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1000 lines, -9 lines) Patch
A experimental/svg/model/SkSVGAttribute.h View 1 2 3 4 5 6 7 1 chunk +41 lines, -0 lines 0 comments Download
A experimental/svg/model/SkSVGAttribute.cpp View 1 2 3 4 1 chunk +34 lines, -0 lines 0 comments Download
A experimental/svg/model/SkSVGContainer.h View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
A experimental/svg/model/SkSVGContainer.cpp View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
A experimental/svg/model/SkSVGDOM.h View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
A experimental/svg/model/SkSVGDOM.cpp View 1 2 3 4 5 6 7 8 1 chunk +244 lines, -0 lines 0 comments Download
A experimental/svg/model/SkSVGG.h View 1 1 chunk +25 lines, -0 lines 0 comments Download
A experimental/svg/model/SkSVGNode.h View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
A experimental/svg/model/SkSVGNode.cpp View 1 2 3 4 5 1 chunk +60 lines, -0 lines 0 comments Download
A experimental/svg/model/SkSVGPath.h View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
A experimental/svg/model/SkSVGPath.cpp View 1 2 3 4 5 1 chunk +37 lines, -0 lines 0 comments Download
A experimental/svg/model/SkSVGRenderContext.h View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
A experimental/svg/model/SkSVGRenderContext.cpp View 1 2 1 chunk +52 lines, -0 lines 0 comments Download
A experimental/svg/model/SkSVGSVG.h View 1 1 chunk +25 lines, -0 lines 0 comments Download
A + experimental/svg/model/SkSVGSVG.cpp View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
A experimental/svg/model/SkSVGTransformableNode.h View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
A experimental/svg/model/SkSVGTransformableNode.cpp View 1 2 3 4 5 1 chunk +26 lines, -0 lines 0 comments Download
A experimental/svg/model/SkSVGValue.h View 1 2 3 4 5 1 chunk +59 lines, -0 lines 0 comments Download
A + experimental/svg/model/SkSVGValue.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M gyp/samples.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M gyp/svg.gyp View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
M include/xml/SkDOM.h View 1 1 chunk +1 line, -1 line 0 comments Download
M include/xml/SkXMLParser.h View 1 chunk +4 lines, -4 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 2 3 4 5 6 3 chunks +26 lines, -0 lines 0 comments Download
A samplecode/SampleSVGFile.cpp View 1 2 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
f(malita)
At this point I'm not sure where this is headed, but it does render some ...
4 years, 4 months ago (2016-07-26 18:47:02 UTC) #4
reed1
lgtm
4 years, 4 months ago (2016-07-26 20:27:20 UTC) #5
robertphillips
lgtm https://codereview.chromium.org/2164193002/diff/120001/experimental/svg/model/SkSVGAttribute.h File experimental/svg/model/SkSVGAttribute.h (right): https://codereview.chromium.org/2164193002/diff/120001/experimental/svg/model/SkSVGAttribute.h#newcode13 experimental/svg/model/SkSVGAttribute.h:13: do we need this include ?
4 years, 4 months ago (2016-07-26 22:38:07 UTC) #6
f(malita)
https://codereview.chromium.org/2164193002/diff/120001/experimental/svg/model/SkSVGAttribute.h File experimental/svg/model/SkSVGAttribute.h (right): https://codereview.chromium.org/2164193002/diff/120001/experimental/svg/model/SkSVGAttribute.h#newcode13 experimental/svg/model/SkSVGAttribute.h:13: On 2016/07/26 22:38:07, robertphillips wrote: > do we need ...
4 years, 4 months ago (2016-07-27 00:51:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164193002/140001
4 years, 4 months ago (2016-07-27 00:51:43 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot/builds/8338) Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on master.client.skia.compile (JOB_FAILED, ...
4 years, 4 months ago (2016-07-27 00:55:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164193002/160001
4 years, 4 months ago (2016-07-27 01:03:09 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 01:46:39 UTC) #17
Message was sent while issue was closed. 
Committed patchset #9 (id:160001) as
https://skia.googlesource.com/skia/+/6ceef3dd67617c5f4572ada98d5ee85777d2db99

Powered by Google App Engine
This is Rietveld 408576698