third_party/WebKit/Tools/Scripts/webkitpy/common/config/urls.py - Issue 2164153002: Reland of refactor the buildbot module in webkitpy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/config/urls.py

Issue 2164153002: Reland of refactor the buildbot module in webkitpy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add latest_layout_test_results to BuildBot and use it in build_data(). Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py » ('j') | third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/config/urls.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/config/urls.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/config/urls.py

index e6c06ed1b4e37386e98ffc74a404651f2c532f4e..7c9b19c5dedd6a8731287fd0f4f977b3a6098006 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/config/urls.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/config/urls.py

@@ -26,20 +26,6 @@

# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE

# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-import re

+# FIXME: this could be moved over to perftestsrunner (the one place where it's used).

def view_source_url(local_path):

return "https://src.chromium.org/viewvc/blink/trunk/%s" % local_path

-def chromium_results_url_base():

- return 'https://storage.googleapis.com/chromium-layout-test-archives'

-def chromium_results_url_base_for_builder(builder_name):

- return '%s/%s' % (chromium_results_url_base(), re.sub('[ .()]', '_', builder_name))

-def chromium_accumulated_results_url_base_for_builder(builder_name):

- return chromium_results_url_base_for_builder(builder_name) + "/results/layout-test-results"