Use the max use count on autofill profile merge.

Use the max use count on autofill profile merge.

This CL retains the maximum autofill profile use-count,
instead of summing the use-counts, when merging two
profiles.

The previous behaviour, summing, inflates the use-count
during profile deduplication, double counts on profile
usage, and falsely counts a fully-typed submission as a
reuse of any profile it matched. All of these skew the
frecency score of the resulting merged profile.

BUG=629978
R=mathp@chromium.org, sebsg@chromium.org

Committed: https://crrev.com/aea4be33481181302f394083e1e046d1ea65bbee
Cr-Commit-Position: refs/heads/master@{#407156}

[Roger McFarlane (Chromium), 2016-07-21 13:48:59]

The CQ bit was checked by rogerm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 13:49:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 14:23:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 14:23:59]

Dry run: This issue passed the CQ dry run.

[Roger McFarlane (Chromium), 2016-07-21 19:02:16]

The CQ bit was checked by rogerm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 19:03:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Roger McFarlane (Chromium), 2016-07-21 19:10:41]

rogerm@chromium.org changed reviewers:
+ zea@chromium.org

[Roger McFarlane (Chromium), 2016-07-21 19:10:42]

Please take a look.

[Mathieu, 2016-07-21 19:16:01]

lgtm, thanks for looking at this.

https://codereview.chromium.org/2164143002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_profile.cc (right):

https://codereview.chromium.org/2164143002/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_profile.cc:467:
set_use_count(std::max(profile.use_count(), use_count()));
Let's add the rationale for the future reader!

[sebsg, 2016-07-21 19:20:15]

LGTM, thanks!

[Nicolas Zea, 2016-07-21 19:25:32]

sync LGTM

[commit-bot: I haz the power, 2016-07-21 19:37:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 19:37:29]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Roger McFarlane (Chromium), 2016-07-22 01:11:33]

The CQ bit was checked by rogerm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 01:12:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Roger McFarlane (Chromium), 2016-07-22 01:14:49]

Description was changed from

==========
Use the max use count on autofill profile merge.

This CL retains the maximum autofill profile use-count, instead of
summing the use-counts, when merging two profiles.

BUG=629978
R=mathp@chromium.org, sebsg@chromium.org
==========

to

==========
Use the max use count on autofill profile merge.

This CL retains the maximum autofill profile use-count,
instead of summing the use-counts, when merging two
profiles.

The previous behaviour, summing, inflates the use-count
during profile deduplication, double counts on profile
usage, and falsely counts a fully-typed submission as a
reuse of any profile it matched. All of these skew the
frecency score of the resulting merged profile.

BUG=629978
R=mathp@chromium.org, sebsg@chromium.org
==========

[Roger McFarlane (Chromium), 2016-07-22 01:15:25]

Thanks.

Improved the comments and CL description.

https://codereview.chromium.org/2164143002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_profile.cc (right):

https://codereview.chromium.org/2164143002/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_profile.cc:467:
set_use_count(std::max(profile.use_count(), use_count()));
On 2016/07/21 19:16:01, Mathieu Perreault wrote:
> Let's add the rationale for the future reader!

Done.

[commit-bot: I haz the power, 2016-07-22 02:29:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 02:29:03]

Dry run: This issue passed the CQ dry run.

[Roger McFarlane (Chromium), 2016-07-22 14:41:32]

The CQ bit was checked by rogerm@chromium.org

[Roger McFarlane (Chromium), 2016-07-22 14:41:32]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org,
sebsg@chromium.org, zea@chromium.org
Link to the patchset: https://codereview.chromium.org/2164143002/#ps40001
(title: "better documentation")

[commit-bot: I haz the power, 2016-07-22 14:41:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 14:45:28]

Description was changed from

==========
Use the max use count on autofill profile merge.

This CL retains the maximum autofill profile use-count,
instead of summing the use-counts, when merging two
profiles.

The previous behaviour, summing, inflates the use-count
during profile deduplication, double counts on profile
usage, and falsely counts a fully-typed submission as a
reuse of any profile it matched. All of these skew the
frecency score of the resulting merged profile.

BUG=629978
R=mathp@chromium.org, sebsg@chromium.org
==========

to

==========
Use the max use count on autofill profile merge.

This CL retains the maximum autofill profile use-count,
instead of summing the use-counts, when merging two
profiles.

The previous behaviour, summing, inflates the use-count
during profile deduplication, double counts on profile
usage, and falsely counts a fully-typed submission as a
reuse of any profile it matched. All of these skew the
frecency score of the resulting merged profile.

BUG=629978
R=mathp@chromium.org, sebsg@chromium.org
==========

[commit-bot: I haz the power, 2016-07-22 14:45:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-22 14:47:12]

Description was changed from

==========
Use the max use count on autofill profile merge.

This CL retains the maximum autofill profile use-count,
instead of summing the use-counts, when merging two
profiles.

The previous behaviour, summing, inflates the use-count
during profile deduplication, double counts on profile
usage, and falsely counts a fully-typed submission as a
reuse of any profile it matched. All of these skew the
frecency score of the resulting merged profile.

BUG=629978
R=mathp@chromium.org, sebsg@chromium.org
==========

to

==========
Use the max use count on autofill profile merge.

This CL retains the maximum autofill profile use-count,
instead of summing the use-counts, when merging two
profiles.

The previous behaviour, summing, inflates the use-count
during profile deduplication, double counts on profile
usage, and falsely counts a fully-typed submission as a
reuse of any profile it matched. All of these skew the
frecency score of the resulting merged profile.

BUG=629978
R=mathp@chromium.org, sebsg@chromium.org

Committed: https://crrev.com/aea4be33481181302f394083e1e046d1ea65bbee
Cr-Commit-Position: refs/heads/master@{#407156}
==========

[commit-bot: I haz the power, 2016-07-22 14:47:13]

Patchset 3 (id:??) landed as
https://crrev.com/aea4be33481181302f394083e1e046d1ea65bbee
Cr-Commit-Position: refs/heads/master@{#407156}