Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2164133002: Moves DCHECK so that it might actually hit (Closed)

Created:
4 years, 5 months ago by sky
Modified:
4 years, 5 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves DCHECK so that it might actually hit The way the DCHECKs are now we won't know if an associated interface has been created. By moving the DCHECK earlier on we can know if that is the cause. BUG=626869 TEST=none R=yzshen@chromium.org Committed: https://crrev.com/8b5e32c68d238a4143ac391db41f1a673143c3d8 Cr-Commit-Position: refs/heads/master@{#406685}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M services/ui/ws/window_tree.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
sky
4 years, 5 months ago (2016-07-20 21:08:50 UTC) #1
yzshen1
lgtm
4 years, 5 months ago (2016-07-20 21:10:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164133002/1
4 years, 5 months ago (2016-07-20 21:16:07 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 22:11:24 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 22:13:24 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b5e32c68d238a4143ac391db41f1a673143c3d8
Cr-Commit-Position: refs/heads/master@{#406685}

Powered by Google App Engine
This is Rietveld 408576698