Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1022)

Issue 2164113003: [M53] service worker: Wait for inflight requests before activating (Closed)

Created:
4 years, 5 months ago by falken
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[M53] service worker: Wait for inflight requests before activating This patch makes changes as per discussion at https://github.com/slightlyoff/ServiceWorker/issues/916 Namely, * The waiting worker gets promoted to active once there are no controllees and the incumbent worker has no in-flight events (fetch/sync/push/message etc). * skipWaiting bypasses the no controllees requirement, but we still wait until there are no in-flight events. * As usual, incoming fetch/sync/push events always go to the active worker. BUG=616331 Review-Url: https://codereview.chromium.org/2119143002 Cr-Commit-Position: refs/heads/master@{#405628} (cherry picked from commit 6c95b0ff8f694cda918e38c96387e5445713fc8e) Committed: https://chromium.googlesource.com/chromium/src/+/2d740ca87cb68f2fbc558a34eb1f1e8328dd6470

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
falken
4 years, 5 months ago (2016-07-21 05:58:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2d740ca87cb68f2fbc558a34eb1f1e8328dd6470.

Powered by Google App Engine
This is Rietveld 408576698