Clean up steps in Chromedriver recipe.

Clean up steps in Chromedriver recipe.

The tempfile recipe module creates a few messy looking steps and
the steps on the Chromedriver bot look very confusing and
unorganized. Adding nested steps for the test runs to clean things up.

Additionally, changed the name of server_log to make it unique for
every test run. It is currently always getting uploaded with the name
server_log and just overwriting itself.

BUG=627633
Committed: https://chromium.googlesource.com/chromium/tools/build/+/3e11cab002795b08e77622dd69fecddf72ee926e

[mikecase (-- gone --), 2016-07-20 17:47:48]

mikecase@chromium.org changed reviewers:
+ jbudorick@chromium.org, samuong@chromium.org

[mikecase (-- gone --), 2016-07-20 20:53:27]

Description was changed from

==========
Clean up steps in Chromedriver recipe.

The tempfile recipe module creates a few messy looking steps and
the steps on the Chromedriver bot look very confusing and
unorganized. Removing use of tempfile module, and adding a nested
step for the test runs to clean things up.

BUG=627633
==========

to

==========
Clean up steps in Chromedriver recipe.

The tempfile recipe module creates a few messy looking steps and
the steps on the Chromedriver bot look very confusing and
unorganized. Removing use of tempfile module, and adding a nested
step for the test runs to clean things up.

Additionally, changed the name of server_log to make it unique for
every test run. It is currently always getting uploaded with the name
server_log and just overwriting itself.

BUG=627633
==========

[mikecase (-- gone --), 2016-07-20 20:55:40]

mikecase@chromium.org changed reviewers:
+ yolandyan@chromium.org

[mikecase (-- gone --), 2016-07-20 20:55:41]

Updated CL to give server_logs unique names (currently it just overwrites itself
when uploaded)

[the real yoland, 2016-07-20 21:25:54]

https://codereview.chromium.org/2164043002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromedriver/api.py (right):

https://codereview.chromium.org/2164043002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromedriver/api.py:149: server_log_dir =
self.m.path.mkdtemp('server_log')
you can still use temp_dir context manager

[mikecase (-- gone --), 2016-07-20 21:46:22]

https://codereview.chromium.org/2164043002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromedriver/api.py (right):

https://codereview.chromium.org/2164043002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromedriver/api.py:149: server_log_dir =
self.m.path.mkdtemp('server_log')
On 2016/07/20 at 21:25:54, the real yoland wrote:
> you can still use temp_dir context manager

This was a good idea. Switched to use the temp_dir context manager about 5
places in this file to clean up the code.

[jbudorick, 2016-07-20 21:49:22]

https://codereview.chromium.org/2164043002/diff/40001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromedriver/api.py (right):

https://codereview.chromium.org/2164043002/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromedriver/api.py:155: def run_java_tests(self,
chromedriver, chrome=None, chrome_version_name=None,
These two functions seem very similar % test_name and test_script_path. Would
unifying them (or  maybe just their implementation) make sense?

[mikecase (-- gone --), 2016-07-20 21:54:22]

Description was changed from

==========
Clean up steps in Chromedriver recipe.

The tempfile recipe module creates a few messy looking steps and
the steps on the Chromedriver bot look very confusing and
unorganized. Removing use of tempfile module, and adding a nested
step for the test runs to clean things up.

Additionally, changed the name of server_log to make it unique for
every test run. It is currently always getting uploaded with the name
server_log and just overwriting itself.

BUG=627633
==========

to

==========
Clean up steps in Chromedriver recipe.

The tempfile recipe module creates a few messy looking steps and
the steps on the Chromedriver bot look very confusing and
unorganized. Adding nested steps for the test runs to clean things up.

Additionally, changed the name of server_log to make it unique for
every test run. It is currently always getting uploaded with the name
server_log and just overwriting itself.

BUG=627633
==========

[mikecase (-- gone --), 2016-07-20 22:50:20]

https://codereview.chromium.org/2164043002/diff/40001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromedriver/api.py (right):

https://codereview.chromium.org/2164043002/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromedriver/api.py:155: def run_java_tests(self,
chromedriver, chrome=None, chrome_version_name=None,
On 2016/07/20 at 21:49:22, jbudorick wrote:
> These two functions seem very similar % test_name and test_script_path. Would
unifying them (or  maybe just their implementation) make sense?

Factored out their common implementation into a _run_test() function

[jbudorick, 2016-07-20 22:51:04]

lgtm

[mikecase (-- gone --), 2016-07-20 23:00:25]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2016-07-20 23:00:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 23:09:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 23:09:59]

Try jobs failed on following builders:
  Build Presubmit on master.tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

[mikecase (-- gone --), 2016-07-20 23:21:24]

The CQ bit was checked by mikecase@chromium.org

[mikecase (-- gone --), 2016-07-20 23:21:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/2164043002/#ps80001
(title: "Fix expectation file.")

[commit-bot: I haz the power, 2016-07-20 23:21:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 23:26:07]

Description was changed from

==========
Clean up steps in Chromedriver recipe.

The tempfile recipe module creates a few messy looking steps and
the steps on the Chromedriver bot look very confusing and
unorganized. Adding nested steps for the test runs to clean things up.

Additionally, changed the name of server_log to make it unique for
every test run. It is currently always getting uploaded with the name
server_log and just overwriting itself.

BUG=627633
==========

to

==========
Clean up steps in Chromedriver recipe.

The tempfile recipe module creates a few messy looking steps and
the steps on the Chromedriver bot look very confusing and
unorganized. Adding nested steps for the test runs to clean things up.

Additionally, changed the name of server_log to make it unique for
every test run. It is currently always getting uploaded with the name
server_log and just overwriting itself.

BUG=627633

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/3e11cab002795b08e776...
==========

[commit-bot: I haz the power, 2016-07-20 23:26:08]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/tools/build/+/3e11cab002795b08e776...