Add 'CFI Linux Full' buildbot (src part).

Add 'CFI Linux Full' buildbot (src part).

'CFI Linux Full' buildbot is similar to 'CFI Linux', but also enables
bad cast checks, which while are not scheduled to be released
to the official Chrome in the nearest future, provide an important
feedback on the bad casts in Chrome. We also want to track any
regressions, so when we're ready to launch them, no additional
cleanup is required.

Also, enabling cfi_cast checks on a number of bots.

BUG=626794
Committed: https://crrev.com/27490f9605648a3697251f616e71e734e9ca3424
Cr-Commit-Position: refs/heads/master@{#406773}

[krasin1, 2016-07-20 22:21:26]

krasin@chromium.org changed reviewers:
+ dpranke@chromium.org, krasin@chromium.org

[Dirk Pranke, 2016-07-20 22:40:41]

Can we pick a different name for this? This is too close for my liking to the
chromecast linux bot, aka "Cast Linux".

[krasin1, 2016-07-20 22:45:23]

On 2016/07/20 22:40:41, Dirk Pranke wrote:
> Can we pick a different name for this? This is too close for my liking to the
> chromecast linux bot, aka "Cast Linux".

That's a very good point. How about 'CFI Linux Full', where Full means that all
CFI checks are enabled (vptr, cast, etc)

[Dirk Pranke, 2016-07-20 23:23:36]

On 2016/07/20 22:45:23, krasin1 wrote:
> On 2016/07/20 22:40:41, Dirk Pranke wrote:
> > Can we pick a different name for this? This is too close for my liking to
the
> > chromecast linux bot, aka "Cast Linux".
> 
> That's a very good point. How about 'CFI Linux Full', where Full means that
all
> CFI checks are enabled (vptr, cast, etc)

Works for me.

[krasin1, 2016-07-20 23:27:34]

Rename is done. Please, take a look.

[Dirk Pranke, 2016-07-20 23:29:54]

lgtm if you agree w/ my suggestions.

https://codereview.chromium.org/2164033003/diff/20001/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2164033003/diff/20001/tools/mb/mb_config.pyl#...
tools/mb/mb_config.pyl:1090: 'gn', 'cfi', 'cfi_cast', 'cfi_diag', 'release',
'static',
The 'cfi_cast' mixin should just include the 'cfi' mixin, since it's not like
you will want the former w/o the later.

https://codereview.chromium.org/2164033003/diff/20001/tools/mb/mb_config.pyl#...
tools/mb/mb_config.pyl:1941: 'cfi_cast': {
i.e., add 'mixins': ['cfi'] here.

[Dirk Pranke, 2016-07-20 23:30:13]

Though, don't forget to also update the CL description.

[krasin1, 2016-07-20 23:34:00]

Description was changed from

==========
Add 'CFI Linux Cast' buildbot (src part).

'CFI Linux Cast' buildbot is similar to 'CFI Linux', but also enables
bad cast checks, which while are not scheduled to be released
to the official Chrome in the nearest future, provide an important
feedback on the bad casts in Chrome. We also want to track any
regressions, so when we're ready to launch them, no additional
cleanup is required.

Also, enabling cfi_cast checks on a number of bots.

BUG=626794
==========

to

==========
Add 'CFI Linux Full' buildbot (src part).

'CFI Linux Full' buildbot is similar to 'CFI Linux', but also enables
bad cast checks, which while are not scheduled to be released
to the official Chrome in the nearest future, provide an important
feedback on the bad casts in Chrome. We also want to track any
regressions, so when we're ready to launch them, no additional
cleanup is required.

Also, enabling cfi_cast checks on a number of bots.

BUG=626794
==========

[krasin1, 2016-07-20 23:34:21]

Please, take a final look, as I am not 100% in the right use of the mixins.

https://codereview.chromium.org/2164033003/diff/20001/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2164033003/diff/20001/tools/mb/mb_config.pyl#...
tools/mb/mb_config.pyl:1090: 'gn', 'cfi', 'cfi_cast', 'cfi_diag', 'release',
'static',
On 2016/07/20 23:29:54, Dirk Pranke wrote:
> The 'cfi_cast' mixin should just include the 'cfi' mixin, since it's not like
> you will want the former w/o the later.

Done.

https://codereview.chromium.org/2164033003/diff/20001/tools/mb/mb_config.pyl#...
tools/mb/mb_config.pyl:1941: 'cfi_cast': {
On 2016/07/20 23:29:54, Dirk Pranke wrote:
> i.e., add 'mixins': ['cfi'] here.

This is a great suggestion: not only it makes it harder to make a mistake, it
also allowed to rename cfi_cast to cfi_full, so there's even less name
confusion.

[Dirk Pranke, 2016-07-20 23:38:26]

lgtm w/ nit.

https://codereview.chromium.org/2164033003/diff/40001/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2164033003/diff/40001/tools/mb/mb_config.pyl#...
tools/mb/mb_config.pyl:1089: 'gn_cfi_full_diag_release_static': [
Technically this should be called 'gn_cfi_full_cfi_diag_release_static', because
the style is to just form the name from the list of mixins joined with
underscores.

But, not the end of the world if we don't clean that up.

[krasin1, 2016-07-20 23:41:36]

https://codereview.chromium.org/2164033003/diff/40001/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2164033003/diff/40001/tools/mb/mb_config.pyl#...
tools/mb/mb_config.pyl:1089: 'gn_cfi_full_diag_release_static': [
On 2016/07/20 23:38:26, Dirk Pranke wrote:
> Technically this should be called 'gn_cfi_full_cfi_diag_release_static',
because
> the style is to just form the name from the list of mixins joined with
> underscores.
> 
> But, not the end of the world if we don't clean that up.

Done.

[krasin1, 2016-07-20 23:41:44]

The CQ bit was checked by krasin@chromium.org

[krasin1, 2016-07-20 23:41:44]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2164033003/#ps60001
(title: "fix style")

[commit-bot: I haz the power, 2016-07-20 23:42:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[krasin1, 2016-07-20 23:59:47]

The CQ bit was unchecked by krasin@chromium.org

[krasin1, 2016-07-21 01:11:45]

The CQ bit was checked by krasin@chromium.org

[commit-bot: I haz the power, 2016-07-21 01:12:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 01:32:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 01:32:02]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[krasin1, 2016-07-21 02:31:07]

The CQ bit was checked by krasin@chromium.org

[commit-bot: I haz the power, 2016-07-21 02:31:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 02:35:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 02:35:03]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[krasin, 2016-07-21 05:24:25]

The CQ bit was checked by krasin@google.com

[commit-bot: I haz the power, 2016-07-21 05:24:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 05:53:57]

Description was changed from

==========
Add 'CFI Linux Full' buildbot (src part).

'CFI Linux Full' buildbot is similar to 'CFI Linux', but also enables
bad cast checks, which while are not scheduled to be released
to the official Chrome in the nearest future, provide an important
feedback on the bad casts in Chrome. We also want to track any
regressions, so when we're ready to launch them, no additional
cleanup is required.

Also, enabling cfi_cast checks on a number of bots.

BUG=626794
==========

to

==========
Add 'CFI Linux Full' buildbot (src part).

'CFI Linux Full' buildbot is similar to 'CFI Linux', but also enables
bad cast checks, which while are not scheduled to be released
to the official Chrome in the nearest future, provide an important
feedback on the bad casts in Chrome. We also want to track any
regressions, so when we're ready to launch them, no additional
cleanup is required.

Also, enabling cfi_cast checks on a number of bots.

BUG=626794
==========

[commit-bot: I haz the power, 2016-07-21 05:53:58]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-21 05:55:41]

Description was changed from

==========
Add 'CFI Linux Full' buildbot (src part).

'CFI Linux Full' buildbot is similar to 'CFI Linux', but also enables
bad cast checks, which while are not scheduled to be released
to the official Chrome in the nearest future, provide an important
feedback on the bad casts in Chrome. We also want to track any
regressions, so when we're ready to launch them, no additional
cleanup is required.

Also, enabling cfi_cast checks on a number of bots.

BUG=626794
==========

to

==========
Add 'CFI Linux Full' buildbot (src part).

'CFI Linux Full' buildbot is similar to 'CFI Linux', but also enables
bad cast checks, which while are not scheduled to be released
to the official Chrome in the nearest future, provide an important
feedback on the bad casts in Chrome. We also want to track any
regressions, so when we're ready to launch them, no additional
cleanup is required.

Also, enabling cfi_cast checks on a number of bots.

BUG=626794

Committed: https://crrev.com/27490f9605648a3697251f616e71e734e9ca3424
Cr-Commit-Position: refs/heads/master@{#406773}
==========

[commit-bot: I haz the power, 2016-07-21 05:55:42]

Patchset 4 (id:??) landed as
https://crrev.com/27490f9605648a3697251f616e71e734e9ca3424
Cr-Commit-Position: refs/heads/master@{#406773}