Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1841)

Unified Diff: chrome/browser/first_run/first_run_unittest.cc

Issue 2164033002: Refactoring startup logic for upcoming FRE changes (non-Win 10). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing comments from grt, excluding structural changes Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/first_run/first_run_unittest.cc
diff --git a/chrome/browser/first_run/first_run_unittest.cc b/chrome/browser/first_run/first_run_unittest.cc
index 47d5d20cce3a8ddac9a7322d883e0a00443a1eda..156391e4442c38107eada8751c624147287a5a85 100644
--- a/chrome/browser/first_run/first_run_unittest.cc
+++ b/chrome/browser/first_run/first_run_unittest.cc
@@ -5,13 +5,16 @@
#include "base/compiler_specific.h"
#include "base/files/file_util.h"
#include "base/macros.h"
+#include "base/strings/utf_string_conversions.h"
#include "base/test/scoped_path_override.h"
#include "base/values.h"
#include "chrome/browser/first_run/first_run.h"
#include "chrome/browser/first_run/first_run_internal.h"
#include "chrome/common/chrome_paths.h"
+#include "chrome/common/url_constants.h"
#include "chrome/installer/util/master_preferences.h"
#include "testing/gtest/include/gtest/gtest.h"
+#include "url/gurl.h"
namespace first_run {
@@ -86,4 +89,34 @@ TEST_F(FirstRunTest,
EXPECT_FALSE(out_prefs.welcome_page_on_os_upgrade_enabled);
}
+TEST_F(FirstRunTest, ProcessMasterPrefsTabs) {
+ std::vector<GURL> input;
+ input.push_back(GURL(base::ASCIIToUTF16("https://new_tab_page")));
+ input.push_back(GURL(base::ASCIIToUTF16("https://www.google.com")));
+ input.push_back(GURL(base::ASCIIToUTF16("https://welcome_page")));
+ std::vector<GURL> output = ProcessMasterPrefsTabs(input);
+ ASSERT_EQ(3U, output.size());
+ EXPECT_EQ(GURL(chrome::kChromeUINewTabURL).host(), output[0].host());
+ EXPECT_EQ("www.google.com", output[1].host());
+ EXPECT_EQ(GetWelcomePageURL().host(), output[2].host());
+}
+
+TEST_F(FirstRunTest, GetOnboardingTabs_FirstRun) {
+ SetFirstRunForTesting(true);
+ std::vector<GURL> output = GetOnboardingTabs();
+ if (IsWin10()) {
+ // TODO(tmartino): Update when Win10 is implemented.
+ ASSERT_EQ(0U, output.size());
+ } else {
+ ASSERT_EQ(1U, output.size());
+ EXPECT_EQ(GetWelcomePageURL().host(), output[0].host());
+ }
+}
+
+TEST_F(FirstRunTest, GetOnboardingTabs_SubsequentRun) {
+ SetFirstRunForTesting(false);
+ std::vector<GURL> output = GetOnboardingTabs();
+ ASSERT_TRUE(output.empty());
+}
+
} // namespace first_run

Powered by Google App Engine
This is Rietveld 408576698