Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1857)

Unified Diff: chrome/browser/first_run/first_run_unittest.cc

Issue 2164033002: Refactoring startup logic for upcoming FRE changes (non-Win 10). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Attempting submission Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/first_run/first_run_unittest.cc
diff --git a/chrome/browser/first_run/first_run_unittest.cc b/chrome/browser/first_run/first_run_unittest.cc
index 47d5d20cce3a8ddac9a7322d883e0a00443a1eda..93873d705a0c882c899e809c763d911e1f4547eb 100644
--- a/chrome/browser/first_run/first_run_unittest.cc
+++ b/chrome/browser/first_run/first_run_unittest.cc
@@ -86,4 +86,44 @@ TEST_F(FirstRunTest,
EXPECT_FALSE(out_prefs.welcome_page_on_os_upgrade_enabled);
}
+// No switches and no sentinel present. This is the standard case for first run.
+TEST_F(FirstRunTest, DetermineFirstRunState_FirstRun) {
+ internal::FirstRunState result =
+ internal::DetermineFirstRunState(false, false, false);
+ EXPECT_EQ(internal::FIRST_RUN_TRUE, result);
+}
+
+// Force switch is present, overriding both sentinel and suppress switch.
+TEST_F(FirstRunTest, DetermineFirstRunState_ForceSwitch) {
+ internal::FirstRunState result =
+ internal::DetermineFirstRunState(true, true, true);
+ EXPECT_EQ(internal::FIRST_RUN_TRUE, result);
+
+ result = internal::DetermineFirstRunState(true, true, false);
+ EXPECT_EQ(internal::FIRST_RUN_TRUE, result);
+
+ result = internal::DetermineFirstRunState(false, true, true);
+ EXPECT_EQ(internal::FIRST_RUN_TRUE, result);
+
+ result = internal::DetermineFirstRunState(false, true, false);
+ EXPECT_EQ(internal::FIRST_RUN_TRUE, result);
+}
+
+// No switches, but sentinel present. This is not a first run.
+TEST_F(FirstRunTest, DetermineFirstRunState_NotFirstRun) {
+ internal::FirstRunState result =
+ internal::DetermineFirstRunState(true, false, false);
+ EXPECT_EQ(internal::FIRST_RUN_FALSE, result);
+}
+
+// Suppress switch is present, overriding sentinel state.
+TEST_F(FirstRunTest, DetermineFirstRunState_SuppressSwitch) {
+ internal::FirstRunState result =
+ internal::DetermineFirstRunState(false, false, true);
+ EXPECT_EQ(internal::FIRST_RUN_FALSE, result);
+
+ result = internal::DetermineFirstRunState(true, false, true);
+ EXPECT_EQ(internal::FIRST_RUN_FALSE, result);
+}
+
} // namespace first_run

Powered by Google App Engine
This is Rietveld 408576698