chrome/browser/ui/startup/startup_tab.h - Issue 2164033002: Refactoring startup logic for upcoming FRE changes (non-Win 10).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/startup_tab.h

Issue 2164033002: Refactoring startup logic for upcoming FRE changes (non-Win 10). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Win build issue Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/startup/startup_features.cc ('K') | « chrome/browser/ui/startup/startup_features.cc ('k') | chrome/browser/ui/startup/startup_tab.cc » ('j') | chrome/browser/ui/startup/startup_tab_provider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/startup/startup_tab.h

diff --git a/chrome/browser/ui/startup/startup_tab.h b/chrome/browser/ui/startup/startup_tab.h

index 26bab7c5531fd1ad8ba2ba443820d693d6c4e37b..d94de11a48494c70de2d42507182cb3a4bcc7485 100644

--- a/chrome/browser/ui/startup/startup_tab.h

+++ b/chrome/browser/ui/startup/startup_tab.h

@@ -5,7 +5,6 @@

#ifndef CHROME_BROWSER_UI_STARTUP_STARTUP_TAB_H_

#define CHROME_BROWSER_UI_STARTUP_STARTUP_TAB_H_

-#include <string>

#include <vector>

#include "url/gurl.h"

@@ -13,6 +12,7 @@

// Represents tab data at startup.

struct StartupTab {

StartupTab();

+ StartupTab(const GURL& url, bool is_pinned);

Peter Kasting 2016/09/29 07:23:34 Nit: Random check, is there a way to use C++11 uni

tmartino 2016/09/30 20:55:02 Believe me, I tried. :) But unfortunately, having

~StartupTab();

// The url to load.