Refactoring startup logic for upcoming FRE changes (non-Win 10).

chrome/browser/first_run/first_run.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_FIRST_RUN_FIRST_RUN_H_
 #define CHROME_BROWSER_FIRST_RUN_FIRST_RUN_H_
 
 #include <stdint.h>
 
 #include <string>
@@ skipping 72 matching lines @@
   std::string import_bookmarks_path;
   std::string compressed_variations_seed;
   std::string variations_seed;
   std::string variations_seed_signature;
   std::string suppress_default_browser_prompt_for_version;
 };
 
 // Returns true if this is the first time chrome is run for this user.
 bool IsChromeFirstRun();
 
+// Testing-only function used to confirm behaviors specific to first run (or
+// non-first run).
+void SetFirstRunForTesting(bool is_first_run);
+
 #if defined(OS_MACOSX)
 // Returns true if |command_line|'s switches explicitly specify that first run
 // should be suppressed in the current run.
 bool IsFirstRunSuppressed(const base::CommandLine& command_line);
 #endif
 
 // Returns whether metrics reporting is currently opt-in. This is used to
 // determine if the enable metrics reporting checkbox on first-run should be
 // initially checked. Opt-in means it is not initially checked, opt-out means it
 // is. This is not guaranteed to be correct outside of the first-run situation,
@@ skipping 25 matching lines @@
 // exactly once, so that the browser loads the welcome tab once the
 // message loop gets going.
 void SetShouldShowWelcomePage();
 
 // Returns true if the welcome page should be shown.
 //
 // This will return true only once: The first time it is called after
 // SetShouldShowWelcomePage() is called.
 bool ShouldShowWelcomePage();
 
+// Gets the URL for the "Welcome to Chrome" dialog.
+// TODO(tmartino): Update to return new Welcome page when complete,
+// subject to check against kUseNewFirstRun feature.
+GURL GetWelcomePageURL();
+
+// Returns true iff the current OS is Windows and the version is >= 10.
+bool IsWin10();

[Roger Tawa OOO till Jul 10th, 2016/07/26 15:00:26]

Should put this inside #ifdef OS_WIN, or somehow refactor code so that windows
specific code only appears in first_run_internal_win.cc

[tmartino, 2016/07/27 18:40:43]

For the time being, where we want to use this both in the policy logic and as a
guard against using the new flow at all, things are a lot cleaner this way. I've
added a TODO and will make that move in the CL which adds the Win10 logic (and
therefore removes the guard from startup_browser_creator_impl).

Note that on non-Windows platforms this currently just returns false, so it
doesn't particularly introduce any risk.

+
+// Checks internal state regarding first-run and onboarding, and returns
+// a vector, possibly empty, of tabs to be shown to the user.
+std::vector<GURL> GetOnboardingTabs();
+
+// Iterates over the given tabs, replacing "magic words" designated for
+// use in Master Prefs files with corresponding URLs.
+std::vector<GURL> ProcessMasterPrefsTabs(const std::vector<GURL>& tabs);
+
 // Sets a flag that will cause ShouldDoPersonalDataManagerFirstRun()
 // to return true exactly once, so that the browser loads
 // PersonalDataManager once the main message loop gets going.
 void SetShouldDoPersonalDataManagerFirstRun();
 
 // Returns true if the autofill personal data manager first-run action
 // should be taken.
 //
 // This will return true only once, the first time it is called after
 // SetShouldDoPersonalDataManagerFirstRun() is called.
@@ skipping 37 matching lines @@
 //
 // See chrome/installer/util/master_preferences.h for a description of
 // 'master_preferences' file.
 ProcessMasterPreferencesResult ProcessMasterPreferences(
     const base::FilePath& user_data_dir,
     MasterPrefs* out_prefs);
 
 }  // namespace first_run
 
 #endif  // CHROME_BROWSER_FIRST_RUN_FIRST_RUN_H_