Refactoring startup logic for upcoming FRE changes (non-Win 10).

chrome/browser/ui/startup/startup_tab_provider.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/startup/startup_tab_provider.h"
+
+#include "build/build_config.h"
+#include "chrome/browser/first_run/first_run.h"
+#include "chrome/browser/ui/chrome_pages.h"
+#include "chrome/common/url_constants.h"
+#include "chrome/grit/locale_settings.h"
+#include "ui/base/l10n/l10n_util.h"
+
+#if defined(OS_WIN)
+#include "base/win/windows_version.h"
+#include "chrome/browser/profile_resetter/triggered_profile_resetter.h"
+#include "chrome/browser/profile_resetter/triggered_profile_resetter_factory.h"
+#endif
+
+namespace {
+// Constants: Magic words used by Master Preferences files in place of a URL
+// host to indicate that internal pages should appear on first run.
+constexpr char kNewTabUrlHost[] = "new_tab_page";
+constexpr char kWelcomePageUrlHost[] = "welcome_page";
+}  // namespace
+
+bool StartupTabProviderImpl::AddOnboardingTabs(StartupTabs* output) const {
+#if defined(OS_WIN)
+  // Windows 10 has unique onboarding policies and content.
+  if (base::win::GetVersion() >= base::win::VERSION_WIN10) {
+    // TODO(tmartino): * Add a function, GetWin10SystemState, which gathers
+    //                   system state relevant to Win10 Onboarding and returns
+    //                   a struct.
+    //                 * Add a function, CheckWin10OnboardingTabPolicy, which
+    //                   takes such a struct as input and returns StartupTabs.
+    return false;
+  }
+#endif
+
+  return CheckStandardOnboardingTabPolicy(first_run::IsChromeFirstRun(),
+                                          output);
+}
+
+bool StartupTabProviderImpl::AddDistributionFirstRunTabs(
+    StartupBrowserCreator* browser_creator,
+    StartupTabs* output) const {
+  if (!browser_creator)
+    return false;
+  bool added_tabs = CheckMasterPrefsTabPolicy(
+      first_run::IsChromeFirstRun(), browser_creator->first_run_tabs_, output);
+  browser_creator->first_run_tabs_.clear();
+  return added_tabs;
+}
+
+bool StartupTabProviderImpl::AddResetTriggerTabs(Profile* profile,
+                                                 StartupTabs* output) const {
+  bool has_reset_trigger = false;
+#if defined(OS_WIN)
+  TriggeredProfileResetter* triggered_profile_resetter =
+      TriggeredProfileResetterFactory::GetForBrowserContext(profile_);
+  if (triggered_profile_resetter)
+    has_reset_trigger = triggered_profile_resetter->HasResetTrigger();
+#endif  // defined(OS_WIN)
+  return CheckResetTriggerTabPolicy(has_reset_trigger, output);
+}
+
+bool StartupTabProviderImpl::AddPinnedTabs(StartupTabs* output) const {
+  // TODO(tmartino): Copy/clean up logic from
+  // StartupBrowserCreatorImpl::ProcessSpecifiedUrls.
+  return false;
+}
+
+bool StartupTabProviderImpl::AddPreferencesTabs(StartupTabs* output) const {
+  // TODO(tmartino): Copy/clean up logic from
+  // StartupBrowserCreatorImpl::ProcessStartupUrls.
+  return false;
+}
+
+// static
+bool StartupTabProviderImpl::CheckStandardOnboardingTabPolicy(
+    bool is_first_run,
+    StartupTabs* output) {
+  if (is_first_run) {
+    output->push_back(StartupTab(GetWelcomePageUrl(), false));
+    return true;
+  }
+  return false;
+}
+
+// static
+bool StartupTabProviderImpl::CheckMasterPrefsTabPolicy(
+    bool is_first_run,
+    const std::vector<GURL>& first_run_tabs,
+    StartupTabs* output) {
+  size_t initial_size = output->size();
+  if (is_first_run) {
+    output->reserve(initial_size + first_run_tabs.size());
+    for (const GURL& url : first_run_tabs) {
+      if (url.host() == kNewTabUrlHost) {
+        output->push_back(StartupTab(GURL(chrome::kChromeUINewTabURL), false));
+      } else if (url.host() == kWelcomePageUrlHost) {
+        output->push_back(StartupTab(GetWelcomePageUrl(), false));
+      } else {
+        output->push_back(StartupTab(url, false));
+      }
+    }
+  }
+  return output->size() > initial_size;
+}
+
+// static
+bool StartupTabProviderImpl::CheckResetTriggerTabPolicy(
+    bool profile_has_trigger,
+    StartupTabs* output) {
+  if (profile_has_trigger) {

[grt (UTC plus 2), 2016/09/14 11:21:22]

nit: reverse the logic to get rid of the braces:
  if (!...)
    return false;
  foo;
  return true;

+    output->push_back(StartupTab(GetTriggeredResetSettingsUrl(), false));
+    return true;
+  }
+  return false;
+}
+
+GURL GetWelcomePageUrl() {
+  return GURL(l10n_util::GetStringUTF8(IDS_WELCOME_PAGE_URL));
+}
+
+GURL GetTriggeredResetSettingsUrl() {
+  return GURL(
+      chrome::GetSettingsUrl(chrome::kTriggeredResetProfileSettingsSubPage));
+}