Refactoring startup logic for upcoming FRE changes (non-Win 10).

chrome/browser/ui/startup/startup_tab_provider.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/startup/startup_tab_provider.h"
+
+#include "chrome/browser/first_run/first_run.h"
+#include "chrome/browser/ui/chrome_pages.h"
+#include "chrome/common/url_constants.h"
+#include "chrome/grit/locale_settings.h"
+#include "ui/base/l10n/l10n_util.h"
+
+#if defined(OS_WIN)
+#include "chrome/browser/profile_resetter/triggered_profile_resetter.h"
+#include "chrome/browser/profile_resetter/triggered_profile_resetter_factory.h"
+#endif
+
+namespace {
+// Constants: Magic words used by Master Preferences files in place of a URL
+// host to indicate that internal pages should appear on first run.
+constexpr char kNewTabUrlHost[] = "new_tab_page";
+constexpr char kWelcomePageUrlHost[] = "welcome_page";
+}  // namespace
+
+StartupTabs StartupTabProviderImpl::GetOnboardingTabs() {
+#if defined(OS_WIN)
+  // Windows 10 has unique onboarding policies and content.
+  if (base::win::GetVersion() >= base::win::VERSION_WIN10) {
+    // TODO(tmartino): * Add a function, GetWin10SystemState, which gathers
+    //                   system state relevant to Win10 Onboarding and returns
+    //                   a struct.
+    //                 * Add a function, CheckWin10OnboardingTabPolicy, which
+    //                   takes such a struct as input and returns StartupTabs.
+    return StartupTabs();
+  }
+#endif
+
+  return CheckStandardOnboardingTabPolicy(first_run::IsChromeFirstRun());
+}
+
+StartupTabs StartupTabProviderImpl::GetMasterPreferencesTabs(
+    StartupBrowserCreator* browser_creator) {
+  StartupTabs tabs = CheckMasterPrefsTabPolicy(
+      first_run::IsChromeFirstRun(), browser_creator->first_run_tabs_);
+  browser_creator->first_run_tabs_.clear();
+  return tabs;
+}
+
+StartupTabs StartupTabProviderImpl::GetResetTriggerTabs(Profile* profile) {
+  bool has_reset_trigger = false;
+#if defined(OS_WIN)
+  TriggeredProfileResetter* triggered_profile_resetter =
+      TriggeredProfileResetterFactory::GetForBrowserContext(profile_);
+  if (triggered_profile_resetter) {
+    has_reset_trigger = triggered_profile_resetter->HasResetTrigger();
+  }
+#endif  // defined(OS_WIN)
+  return CheckResetTriggerTabPolicy(has_reset_trigger);
+}
+
+StartupTabs StartupTabProviderImpl::GetPinnedTabs() {
+  // TODO(tmartino): Copy/clean up logic from
+  // StartupBrowserCreatorImpl::ProcessSpecifiedUrls.
+  return StartupTabs();
+}
+
+StartupTabs StartupTabProviderImpl::GetPreferencesTabs() {
+  // TODO(tmartino): Copy/clean up logic from
+  // StartupBrowserCreatorImpl::ProcessStartupUrls.
+  return StartupTabs();
+}
+
+// Private static implementation methods:

[grt (UTC plus 2), 2016/09/09 11:40:30]

remove this

+
+StartupTabs StartupTabProviderImpl::CheckStandardOnboardingTabPolicy(

[grt (UTC plus 2), 2016/09/09 11:40:30]

nit: there's a convention of putting a simple
// static
comment on the line immediately preceding static member function definitions.

+    bool is_first_run) {
+  StartupTabs tabs;
+  if (is_first_run)
+    tabs.push_back(StartupTab(GetWelcomePageUrl(), false));
+  return tabs;
+}
+
+StartupTabs StartupTabProviderImpl::CheckMasterPrefsTabPolicy(
+    bool is_first_run,
+    const std::vector<GURL>& first_run_tabs) {
+  StartupTabs processed_tabs;
+  if (is_first_run) {
+    for (const GURL& url : first_run_tabs) {

[grt (UTC plus 2), 2016/09/09 11:40:30]

nit:
    processed_tabs.reserve(first_run_tabs.size());

+      if (url.host() == kNewTabUrlHost) {
+        processed_tabs.push_back(
+            StartupTab(GURL(chrome::kChromeUINewTabURL), false));
+      } else if (url.host() == kWelcomePageUrlHost) {
+        processed_tabs.push_back(StartupTab(GetWelcomePageUrl(), false));
+      } else {
+        processed_tabs.push_back(StartupTab(url, false));
+      }
+    }
+  }
+  return processed_tabs;
+}
+
+StartupTabs StartupTabProviderImpl::CheckResetTriggerTabPolicy(
+    bool profile_has_trigger) {
+  StartupTabs tabs;
+  if (profile_has_trigger)
+    tabs.push_back(StartupTab(GetTriggeredResetSettingsUrl(), false));
+  return tabs;
+}
+
+GURL GetWelcomePageUrl() {
+  return GURL(l10n_util::GetStringUTF8(IDS_WELCOME_PAGE_URL));
+}
+
+GURL GetTriggeredResetSettingsUrl() {
+  return GURL(
+      chrome::GetSettingsUrl(chrome::kTriggeredResetProfileSettingsSubPage));
+}