chrome/browser/ui/startup/startup_tab.h - Issue 2164033002: Refactoring startup logic for upcoming FRE changes (non-Win 10).

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/startup/startup_tab.h

Issue 2164033002: Refactoring startup logic for upcoming FRE changes (non-Win 10). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding missing constructor Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/startup/startup_browser_creator_impl_unittest.cc ('K') | « chrome/browser/ui/startup/startup_features.cc ('k') | chrome/browser/ui/startup/startup_tab.cc » ('j') | chrome/browser/ui/startup/startup_tab.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_STARTUP_STARTUP_TAB_H_	5 #ifndef CHROME_BROWSER_UI_STARTUP_STARTUP_TAB_H_

6 #define CHROME_BROWSER_UI_STARTUP_STARTUP_TAB_H_	6 #define CHROME_BROWSER_UI_STARTUP_STARTUP_TAB_H_

7	7

8 #include <string>	8 #include <string>
	grt (UTC plus 2) 2016/09/09 11:40:30 nit: remove this unused include while you're here nit: remove this unused include while you're here
9 #include <vector>	9 #include <vector>

10	10

11 #include "url/gurl.h"	11 #include "url/gurl.h"

12	12

13 // Represents tab data at startup.	13 // Represents tab data at startup.

14 struct StartupTab {	14 struct StartupTab {

15 StartupTab();	15 StartupTab();

	16 StartupTab(GURL url_, bool is_pinned_);
	grt (UTC plus 2) 2016/09/09 11:40:30 no '_' in parameter names. no '_' in parameter names. tmartino 2016/09/10 00:19:41 Changed to url_val and is_pinned_val, which feels Show quoted text On 2016/09/09 at 11:40:30, grt (UTC plus 2) wrote: > no '_' in parameter names. Changed to url_val and is_pinned_val, which feels icky. Is there a convention for this situation? grt (UTC plus 2) 2016/09/12 07:28:46 url and is_pinned will work, no? Show quoted text On 2016/09/10 00:19:41, tmartino wrote: > On 2016/09/09 at 11:40:30, grt (UTC plus 2) wrote: > > no '_' in parameter names. > > Changed to url_val and is_pinned_val, which feels icky. Is there a convention > for this situation? url and is_pinned will work, no?
16 ~StartupTab();	17 ~StartupTab();

17	18

18 // The url to load.	19 // The url to load.

19 GURL url;	20 GURL url;

20	21

21 // True if the is tab pinned.	22 // True if the is tab pinned.

22 bool is_pinned;	23 bool is_pinned;

23 };	24 };

24	25

25 typedef std::vector<StartupTab> StartupTabs;	26 typedef std::vector<StartupTab> StartupTabs;

26	27

27 #endif // CHROME_BROWSER_UI_STARTUP_STARTUP_TAB_H_	28 #endif // CHROME_BROWSER_UI_STARTUP_STARTUP_TAB_H_

OLD	NEW