Refactoring startup logic for upcoming FRE changes (non-Win 10).

chrome/browser/first_run/first_run.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_FIRST_RUN_FIRST_RUN_H_
 #define CHROME_BROWSER_FIRST_RUN_FIRST_RUN_H_
 
 #include <stdint.h>
 
 #include <string>
@@ skipping 69 matching lines @@
   bool welcome_page_on_os_upgrade_enabled;
   std::vector<GURL> new_tabs;
   std::vector<GURL> bookmarks;
   std::string import_bookmarks_path;
   std::string compressed_variations_seed;
   std::string variations_seed;
   std::string variations_seed_signature;
   std::string suppress_default_browser_prompt_for_version;
 };
 
+// Struct which accumulates various properties of the current system for
+// determining which, if any, onboarding actions should occur.
+struct FirstRunSystemStatus {
+  // Describes which 'class' of Operating System is running. Any OS's which
+  // have the same onboarding behavior are considered the same class.
+  enum OperatingSystemClass { STANDARD = 0, WINDOWS_10 };
+
+  OperatingSystemClass os_class;
+  bool is_sentinel_present;
+  bool is_force_flag_on;
+  bool is_suppress_flag_on;
+};
+
+// Gathers properties of current system which are relevant for determining
+// onboarding policy.
+FirstRunSystemStatus GetFirstRunSystemStatus();
+
+// Makes policy decisions based on the given system status, and returns

[grt (UTC plus 2), 2016/08/23 10:36:02]

nit: "Returns the (possibly empty) collection of first-run-related tabs to be
shown to the user based on the given system status" or something like that; see
https://google.github.io/styleguide/cppguide.html#Function_Comments.

+// a vector, possibly empty, of first-run-related tabs to be shown to the user.
+std::vector<GURL> GetOnboardingTabs(FirstRunSystemStatus status);
+
 // Returns true if this is the first time chrome is run for this user.
 bool IsChromeFirstRun();
 
 #if defined(OS_MACOSX)
 // Returns true if |command_line|'s switches explicitly specify that first run
 // should be suppressed in the current run.
 bool IsFirstRunSuppressed(const base::CommandLine& command_line);
 #endif
 
 // Returns whether metrics reporting is currently opt-in. This is used to
@@ skipping 28 matching lines @@
 // exactly once, so that the browser loads the welcome tab once the
 // message loop gets going.
 void SetShouldShowWelcomePage();
 
 // Returns true if the welcome page should be shown.
 //
 // This will return true only once: The first time it is called after
 // SetShouldShowWelcomePage() is called.
 bool ShouldShowWelcomePage();
 
+// Gets the URL for the "Welcome to Chrome" dialog.
+// TODO(tmartino): Update to return new Welcome page when complete,
+// subject to check against kUseConsolidatedFirstRun feature.
+GURL GetWelcomePageURL();

[grt (UTC plus 2), 2016/08/23 10:36:02]

URL -> Url (http://google.github.io/styleguide/cppguide.html#Function_Names)

[tmartino, 2016/09/08 21:33:16]

Done (here and throughout)

+
+// Iterates over the given tabs, replacing "magic words" designated for
+// use in Master Prefs files with corresponding URLs.

[grt (UTC plus 2), 2016/08/23 10:36:02]

"Master Prefs" -> "master preferences"

[tmartino, 2016/09/08 21:33:16]

Done

+std::vector<GURL> ProcessMasterPrefsTabs(const std::vector<GURL>& tabs);
+
 // Sets a flag that will cause ShouldDoPersonalDataManagerFirstRun()
 // to return true exactly once, so that the browser loads
 // PersonalDataManager once the main message loop gets going.
 void SetShouldDoPersonalDataManagerFirstRun();
 
 // Returns true if the autofill personal data manager first-run action
 // should be taken.
 //
 // This will return true only once, the first time it is called after
 // SetShouldDoPersonalDataManagerFirstRun() is called.
@@ skipping 37 matching lines @@
 //
 // See chrome/installer/util/master_preferences.h for a description of
 // 'master_preferences' file.
 ProcessMasterPreferencesResult ProcessMasterPreferences(
     const base::FilePath& user_data_dir,
     MasterPrefs* out_prefs);
 
 }  // namespace first_run
 
 #endif  // CHROME_BROWSER_FIRST_RUN_FIRST_RUN_H_