Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2164013002: [OBSOLETE] tracing v2: introduce TraceBufferWriter (Closed)

Created:
4 years, 5 months ago by Primiano Tucci (use gerrit)
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@proto_handle
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tracing v2: introduce TraceBufferWriter TraceBufferWriter is the key building block to write events into the trace ring buffer. It acts as a glue layer between the protobuf classes (ProtoZeroMessage) and the chunks of the trace ring buffer. The expected design is 1 TraceBufferWriter per thread-local TraceLog instance (% special cases where they don't have a thread and use a shared locked instance). BUG=608719 TEST=TODO

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+862 lines, -23 lines) Patch
M components/components_tests.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/tracing.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M components/tracing/BUILD.gn View 1 2 4 chunks +46 lines, -0 lines 0 comments Download
M components/tracing/core/proto_utils.h View 1 chunk +6 lines, -0 lines 0 comments Download
M components/tracing/core/proto_zero_message.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M components/tracing/core/scattered_stream_writer.h View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
A components/tracing/core/trace_buffer_writer.h View 1 2 1 chunk +102 lines, -0 lines 0 comments Download
A components/tracing/core/trace_buffer_writer.cc View 1 2 1 chunk +216 lines, -0 lines 0 comments Download
A components/tracing/core/trace_buffer_writer_unittest.cc View 1 2 1 chunk +312 lines, -0 lines 0 comments Download
M components/tracing/core/trace_ring_buffer.h View 1 2 3 chunks +25 lines, -7 lines 0 comments Download
M components/tracing/core/trace_ring_buffer.cc View 1 2 4 chunks +18 lines, -7 lines 0 comments Download
M components/tracing/core/trace_ring_buffer_unittest.cc View 1 2 3 chunks +10 lines, -7 lines 0 comments Download
A components/tracing/proto/event.proto View 1 2 1 chunk +61 lines, -0 lines 0 comments Download
A components/tracing/proto/event_args_for_testing.proto View 1 1 chunk +19 lines, -0 lines 0 comments Download
A components/tracing/proto/events_chunk.proto View 1 2 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (9 generated)
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org to run a CQ dry run
4 years, 5 months ago (2016-07-20 16:18:04 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164013002/1
4 years, 5 months ago (2016-07-20 16:18:35 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 5 months ago (2016-07-20 16:43:49 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/248121)
4 years, 5 months ago (2016-07-20 16:43:49 UTC) #4
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-07-28 18:15:16 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164013002/40001
4 years, 4 months ago (2016-07-28 18:15:37 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-07-28 18:52:12 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/229266)
4 years, 4 months ago (2016-07-28 18:52:13 UTC) #8
Primiano Tucci (use gerrit)
4 years, 3 months ago (2016-09-05 14:23:28 UTC) #9 
Description was changed from

==========
tracing v2: introduce TraceBufferWriter

TraceBufferWriter is the key building block to write events into the
trace ring buffer. It acts as a glue layer between the protobuf classes
(ProtoZeroMessage) and the chunks of the trace ring buffer.
The expected design is 1 TraceBufferWriter per thread-local
TraceLog instance (% special cases where they don't have a thread
and use a shared locked instance).

BUG=608719
TEST=TODO
==========

to

==========
tracing v2: introduce TraceBufferWriter

TraceBufferWriter is the key building block to write events into the
trace ring buffer. It acts as a glue layer between the protobuf classes
(ProtoZeroMessage) and the chunks of the trace ring buffer.
The expected design is 1 TraceBufferWriter per thread-local
TraceLog instance (% special cases where they don't have a thread
and use a shared locked instance).

BUG=608719
TEST=TODO
==========

Powered by Google App Engine
This is Rietveld 408576698