Split onResourcesLoaded into multiple functions.

build/android/gyp/process_resources.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Process Android resources to generate R.java, and prepare for packaging.
 
 This will crunch images and generate v14 compatible resources
 (see generate_v14_compatible_resources.py).
@@ skipping 206 matching lines @@
         public static {{ e.java_type }} {{ e.name }} = {{ e.value }};
         {% else %}
         public static final {{ e.java_type }} {{ e.name }} = {{ e.value }};
         {% endif %}
         {% endfor %}
     }
     {% endfor %}
     {% if shared_resources %}
     public static void onResourcesLoaded(int packageId) {
         {% for resource_type in resource_types %}
-        {% for e in resources[resource_type] %}
-        {% if resource_type != 'styleable' and e.java_type != 'int[]' %}
-        """ + create_id + """
-        {% endif %}
-        {% endfor %}
+        onResourcesLoaded{{ resource_type|title }}(packageId);

[agrieve, 2016/07/20 17:21:36]

Actually, please do a add a {# comment #} here pointing out that this differs
from aapt and is required to work around this method size error.

         {% for e in resources[resource_type] %}
         {% if e.java_type == 'int[]' %}
         for(int i = 0; i < {{ e.resource_type }}.{{ e.name }}.length; ++i) {
             """ + create_id_arr + """
         }
         {% endif %}
         {% endfor %}
         {% endfor %}
     }
+    {% for resource_type in resource_types %}
+    private static void onResourcesLoaded{{ resource_type|title }}(int packageId) {

[PEConn, 2016/07/20 15:58:40]

This exceeds the line length limit but in a template string. I'm not sure if
this is acceptable and if not, what a preferable formatting is.

[PEConn, 2016/07/20 16:58:26]

The line length is causing the presubmit to fail.

[Bernhard Bauer, 2016/07/20 17:08:33]

This is just a string, right? You could construct the string from shorter
strings somehow.

(Also, this problem seems kind of meta. :D )

[agrieve, 2016/07/20 17:20:27]

yeah, I'd say choose a shorter variable name for packageId or resource_type and
then move along :P

[PEConn, 2016/07/20 17:41:37]

Done.

+        {% for e in resources[resource_type] %}
+        {% if resource_type != 'styleable' and e.java_type != 'int[]' %}
+        """ + create_id + """
+        {% endif %}
+        {% endfor %}
+    }
+    {% endfor %}
     {% endif %}
 }
 """, trim_blocks=True, lstrip_blocks=True)
 
   return template.render(package=package,
                          resources=resources_by_type,
                          resource_types=sorted(resources_by_type),
                          shared_resources=shared_resources)
 
 
@@ skipping 272 matching lines @@
       options,
       input_paths=input_paths,
       input_strings=input_strings,
       output_paths=output_paths,
       # TODO(agrieve): Remove R_dir when it's no longer used (used only by GYP).
       force=options.R_dir)
 
 
 if __name__ == '__main__':
   main(sys.argv[1:])