Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: content/browser/media/webrtc/webrtc_internals_message_handler.cc

Issue 2163983006: Add unit test for WebRTCInternalsMessageHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add NON_EXPORTED_BASE annotation. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/webrtc/webrtc_internals_message_handler.cc
diff --git a/content/browser/media/webrtc/webrtc_internals_message_handler.cc b/content/browser/media/webrtc/webrtc_internals_message_handler.cc
index ea74c5bb4eca30dc2b3128187ee24fc3e1a4ec1c..48e45c52ed2e906b1781ced9f451d55623058f33 100644
--- a/content/browser/media/webrtc/webrtc_internals_message_handler.cc
+++ b/content/browser/media/webrtc/webrtc_internals_message_handler.cc
@@ -15,12 +15,17 @@
namespace content {
-WebRTCInternalsMessageHandler::WebRTCInternalsMessageHandler() {
- WebRTCInternals::GetInstance()->AddObserver(this);
+WebRTCInternalsMessageHandler::WebRTCInternalsMessageHandler()
+ : WebRTCInternalsMessageHandler(WebRTCInternals::GetInstance()) {}
+
+WebRTCInternalsMessageHandler::WebRTCInternalsMessageHandler(
+ WebRTCInternals* webrtc_internals)
+ : webrtc_internals_(webrtc_internals) {
+ webrtc_internals_->AddObserver(this);
}
WebRTCInternalsMessageHandler::~WebRTCInternalsMessageHandler() {
- WebRTCInternals::GetInstance()->RemoveObserver(this);
+ webrtc_internals_->RemoveObserver(this);
}
void WebRTCInternalsMessageHandler::RegisterMessages() {
@@ -84,10 +89,9 @@ void WebRTCInternalsMessageHandler::OnGetAllStats(
void WebRTCInternalsMessageHandler::OnSetAudioDebugRecordingsEnabled(
bool enable, const base::ListValue* /* unused_list */) {
if (enable) {
- WebRTCInternals::GetInstance()->EnableAudioDebugRecordings(
- web_ui()->GetWebContents());
+ webrtc_internals_->EnableAudioDebugRecordings(web_ui()->GetWebContents());
} else {
- WebRTCInternals::GetInstance()->DisableAudioDebugRecordings();
+ webrtc_internals_->DisableAudioDebugRecordings();
}
}
@@ -95,18 +99,17 @@ void WebRTCInternalsMessageHandler::OnSetEventLogRecordingsEnabled(
bool enable,
const base::ListValue* /* unused_list */) {
if (enable) {
- WebRTCInternals::GetInstance()->EnableEventLogRecordings(
- web_ui()->GetWebContents());
+ webrtc_internals_->EnableEventLogRecordings(web_ui()->GetWebContents());
} else {
- WebRTCInternals::GetInstance()->DisableEventLogRecordings();
+ webrtc_internals_->DisableEventLogRecordings();
}
}
void WebRTCInternalsMessageHandler::OnDOMLoadDone(
const base::ListValue* /* unused_list */) {
- WebRTCInternals::GetInstance()->UpdateObserver(this);
+ webrtc_internals_->UpdateObserver(this);
- if (WebRTCInternals::GetInstance()->IsAudioDebugRecordingsEnabled()) {
+ if (webrtc_internals_->IsAudioDebugRecordingsEnabled()) {
RenderFrameHost* host = GetWebRTCInternalsHost();
if (!host)
return;

Powered by Google App Engine
This is Rietveld 408576698