Add unit test for WebRTCInternalsMessageHandler.

content/browser/media/webrtc/webrtc_internals_message_handler_unittest.cc

Index: content/browser/media/webrtc/webrtc_internals_message_handler_unittest.cc
diff --git a/content/browser/media/webrtc/webrtc_internals_message_handler_unittest.cc b/content/browser/media/webrtc/webrtc_internals_message_handler_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d66ae5fab6b36bbc1329861dda92188146219434
--- /dev/null
+++ b/content/browser/media/webrtc/webrtc_internals_message_handler_unittest.cc
@@ -0,0 +1,90 @@
+// Copyright (c) 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/media/webrtc/webrtc_internals_message_handler.h"
+
+#include <memory>
+#include <string>
+
+#include "base/run_loop.h"
+#include "content/browser/child_process_security_policy_impl.h"
+#include "content/browser/media/webrtc/webrtc_internals.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/common/url_constants.h"
+#include "content/public/test/test_web_ui.h"
+#include "content/test/test_web_contents.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace content {
+
+namespace {
+
+static const char kConstraints[] = "c";
+static const char kRtcConfiguration[] = "r";
+static const char kUrl[] = "u";
+
+class WebRTCInternalsMessageHandlerForTest
+    : public WebRTCInternalsMessageHandler {
+ public:
+  WebRTCInternalsMessageHandlerForTest(WebRTCInternals* webrtc_internals,
+                                       WebUI* web_ui)
+      : WebRTCInternalsMessageHandler(webrtc_internals) {
+    set_web_ui(web_ui);
+  }
+
+  ~WebRTCInternalsMessageHandlerForTest() override {}
+};
+
+class WebRTCInternalsForTest : public NON_EXPORTED_BASE(WebRTCInternals) {
+ public:
+  WebRTCInternalsForTest() : WebRTCInternals(0, false) {}
+  ~WebRTCInternalsForTest() override {}
+};
+
+}  // namespace
+
+class WebRtcInternalsMessageHandlerTest : public RenderViewHostTestHarness {
+ public:
+  WebRtcInternalsMessageHandlerTest() {}
+
+  const GURL webrtc_url_{std::string("chrome://") +

[tommi (sloooow) - chröme, 2016/07/25 11:05:39]

I was actually expecting you to use () here since you weren't using {} for
initialization before.
See guidelines here for what to do:
https://www.chromium.org/developers/coding-style/cpp-dos-and-donts?pli=1#TOC-...

I would have just done:

static const GURL kWebRTCURL(std::string("chrome://") +
kChromeUIWebRTCInternalsHost);
static const GURL kExampleURL("http://www.example.com/");

[Max Morin, 2016/07/25 12:02:57]

Using () makes these function declarations, hence the {}s. I'll just move them
to the test body.

+                         kChromeUIWebRTCInternalsHost};
+  const GURL example_url_{"http://www.example.com/"};
+
+ protected:
+  void SetUp() override {
+    RenderViewHostTestHarness::SetUp();
+    web_ui_.reset(new TestWebUI());
+    web_ui_->set_web_contents(web_contents());
+  }
+
+  void TearDown() override {
+    web_ui_->set_web_contents(nullptr);
+    web_ui_.reset();
+    RenderViewHostTestHarness::TearDown();
+  }
+
+  std::unique_ptr<TestWebUI> web_ui_;
+};
+
+TEST_F(WebRtcInternalsMessageHandlerTest, DontRunJSBeforeNavigationCommitted) {
+  WebRTCInternalsForTest webrtc_internals;
+  WebRTCInternalsMessageHandlerForTest observer(&webrtc_internals,
+                                                web_ui_.get());
+
+  NavigateAndCommit(example_url_);
+  webrtc_internals.OnAddPeerConnection(0, 1, 2, kUrl, kRtcConfiguration,
+                                       kConstraints);
+  base::RunLoop().RunUntilIdle();
+
+  static_cast<TestWebContents*>(web_contents())->StartNavigation(webrtc_url_);
+  // We still shouldn't run JS, since navigation to webrtc-internals isn't
+  // finished.
+  webrtc_internals.OnRemovePeerConnection(1, 2);
+  base::RunLoop().RunUntilIdle();
+
+  webrtc_internals.RemoveObserver(&observer);
+}
+
+}  // namespace content