third_party/harfbuzz-ng/src/hb-font.cc - Issue 2163983005: Roll HarfBuzz to 1.3.0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/harfbuzz-ng/src/hb-font.cc

Issue 2163983005: Roll HarfBuzz to 1.3.0 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/harfbuzz-ng/src/hb-font.cc

diff --git a/third_party/harfbuzz-ng/src/hb-font.cc b/third_party/harfbuzz-ng/src/hb-font.cc

index 6a4823ab5f44ae2aea9cb5a83b222baa9653c322..60554b9c786084032fd04a10598184171ae7bac6 100644

--- a/third_party/harfbuzz-ng/src/hb-font.cc

+++ b/third_party/harfbuzz-ng/src/hb-font.cc

@@ -158,6 +158,7 @@ hb_font_get_glyph_v_advance_nil (hb_font_t *font HB_UNUSED,

hb_codepoint_t glyph,

void *user_data HB_UNUSED)

{

+ /* TODO use font_extents.ascender+descender */

return font->y_scale;

}

static hb_position_t