MIPS: Fix infinite loop in Math.pow(2,-2147483648)

MIPS: Fix infinite loop in Math.pow(2,-2147483648)

BUG=v8:5213
Committed: https://crrev.com/eaa86cbf0612366b4e69006e2410e8d2d8bbafa7
Cr-Commit-Position: refs/heads/master@{#37955}

[ivica.bogosavljevic, 2016-07-20 15:58:24]

Description was changed from

==========
MIPS: Fix infinite loop in Math.pow(2,-2147483648)

BUG=v8:5213
==========

to

==========
MIPS: Fix infinite loop in Math.pow(2,-2147483648)

BUG=v8:5213
==========

[ivica.bogosavljevic, 2016-07-20 15:58:25]

ivica.bogosavljevic@imgtec.com changed reviewers:
+ ahaas@chromium.org, akos.palfi@imgtec.com, balazs.kilvady@imgtec.com

[ivica.bogosavljevic, 2016-07-20 15:58:35]

PTAL

[akos.palfi.imgtec, 2016-07-21 11:23:26]

akos.palfi@imgtec.com changed reviewers:
+ bmeurer@chromium.org

[akos.palfi.imgtec, 2016-07-21 11:23:27]

LGTM with nits.

@Andreas, @Benedikt: PTAL.

https://codereview.chromium.org/2163963003/diff/20001/src/mips/code-stubs-mip...
File src/mips/code-stubs-mips.cc (right):

https://codereview.chromium.org/2163963003/diff/20001/src/mips/code-stubs-mip...
src/mips/code-stubs-mips.cc:830: // (happens only when input is MIN_INT)
Nit: please put period at the end of the sentence.

https://codereview.chromium.org/2163963003/diff/20001/src/mips/code-stubs-mip...
src/mips/code-stubs-mips.cc:831: __ BranchShort(&bail_out, gt, zero_reg,
Operand(scratch));
You should use Branch() instead of BranchShort().

https://codereview.chromium.org/2163963003/diff/20001/src/mips64/code-stubs-m...
File src/mips64/code-stubs-mips64.cc (right):

https://codereview.chromium.org/2163963003/diff/20001/src/mips64/code-stubs-m...
src/mips64/code-stubs-mips64.cc:826: // Check when Subu overflows and we get
negative result
Nit: s/Subu/Dsubu

https://codereview.chromium.org/2163963003/diff/20001/src/mips64/code-stubs-m...
src/mips64/code-stubs-mips64.cc:827: // (happens only when input is MIN_INT)
Nit: please put period at the end of the sentence.

https://codereview.chromium.org/2163963003/diff/20001/src/mips64/code-stubs-m...
src/mips64/code-stubs-mips64.cc:828: __ BranchShort(&bail_out, gt, zero_reg,
Operand(scratch));
You should use Branch() instead of BranchShort().

[ahaas, 2016-07-21 11:37:25]

lgtm

[ivica.bogosavljevic, 2016-07-21 13:22:23]

The CQ bit was checked by ivica.bogosavljevic@imgtec.com

[commit-bot: I haz the power, 2016-07-21 13:22:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ivica.bogosavljevic, 2016-07-21 13:22:56]

The CQ bit was unchecked by ivica.bogosavljevic@imgtec.com

[ivica.bogosavljevic, 2016-07-21 13:50:47]

The CQ bit was checked by ivica.bogosavljevic@imgtec.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 13:50:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 14:14:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 14:14:40]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2016-07-21 17:29:11]

LGTM.

[ivica.bogosavljevic, 2016-07-21 19:32:37]

The CQ bit was checked by ivica.bogosavljevic@imgtec.com

[ivica.bogosavljevic, 2016-07-21 19:32:38]

The patchset sent to the CQ was uploaded after l-g-t-m from ahaas@chromium.org,
akos.palfi@imgtec.com
Link to the patchset: https://codereview.chromium.org/2163963003/#ps40001
(title: "Nits")

[commit-bot: I haz the power, 2016-07-21 19:32:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 19:34:25]

Description was changed from

==========
MIPS: Fix infinite loop in Math.pow(2,-2147483648)

BUG=v8:5213
==========

to

==========
MIPS: Fix infinite loop in Math.pow(2,-2147483648)

BUG=v8:5213
==========

[commit-bot: I haz the power, 2016-07-21 19:34:26]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-21 19:38:15]

Description was changed from

==========
MIPS: Fix infinite loop in Math.pow(2,-2147483648)

BUG=v8:5213
==========

to

==========
MIPS: Fix infinite loop in Math.pow(2,-2147483648)

BUG=v8:5213

Committed: https://crrev.com/eaa86cbf0612366b4e69006e2410e8d2d8bbafa7
Cr-Commit-Position: refs/heads/master@{#37955}
==========

[commit-bot: I haz the power, 2016-07-21 19:38:17]

Patchset 3 (id:??) landed as
https://crrev.com/eaa86cbf0612366b4e69006e2410e8d2d8bbafa7
Cr-Commit-Position: refs/heads/master@{#37955}

[ivica.bogosavljevic, 2016-07-22 14:45:08]

https://codereview.chromium.org/2163963003/diff/20001/src/mips/code-stubs-mip...
File src/mips/code-stubs-mips.cc (right):

https://codereview.chromium.org/2163963003/diff/20001/src/mips/code-stubs-mip...
src/mips/code-stubs-mips.cc:830: // (happens only when input is MIN_INT)
On 2016/07/21 11:23:27, akos.palfi.imgtec wrote:
> Nit: please put period at the end of the sentence.

Acknowledged.

https://codereview.chromium.org/2163963003/diff/20001/src/mips/code-stubs-mip...
src/mips/code-stubs-mips.cc:831: __ BranchShort(&bail_out, gt, zero_reg,
Operand(scratch));
On 2016/07/21 11:23:27, akos.palfi.imgtec wrote:
> You should use Branch() instead of BranchShort().

Acknowledged.

https://codereview.chromium.org/2163963003/diff/20001/src/mips64/code-stubs-m...
File src/mips64/code-stubs-mips64.cc (right):

https://codereview.chromium.org/2163963003/diff/20001/src/mips64/code-stubs-m...
src/mips64/code-stubs-mips64.cc:826: // Check when Subu overflows and we get
negative result
On 2016/07/21 11:23:27, akos.palfi.imgtec wrote:
> Nit: s/Subu/Dsubu

Acknowledged.

https://codereview.chromium.org/2163963003/diff/20001/src/mips64/code-stubs-m...
src/mips64/code-stubs-mips64.cc:827: // (happens only when input is MIN_INT)
On 2016/07/21 11:23:27, akos.palfi.imgtec wrote:
> Nit: please put period at the end of the sentence.

Acknowledged.

https://codereview.chromium.org/2163963003/diff/20001/src/mips64/code-stubs-m...
src/mips64/code-stubs-mips64.cc:828: __ BranchShort(&bail_out, gt, zero_reg,
Operand(scratch));
On 2016/07/21 11:23:27, akos.palfi.imgtec wrote:
> You should use Branch() instead of BranchShort().

Acknowledged.